Repository navigation
script: Use inclusive_ancestors_unrooted in interior of UnrootedFollowingNodeIterator - #47158
Merged
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
yezhizhen
reviewed
Aug 12, 2026
yezhizhen
left a comment
Member
There was a problem hiding this comment.
This saves 0.4% of cpu in a slice on walrusaudio.com
How to measure this?
jdm
approved these changes
Aug 12, 2026
Contributor
Author
|
Measured with samply. Generally when I write 0.4% in slice it is picking a big slice where script thread is maxed and looking at the percentage of samply. |
eachra-bawn
pushed a commit
to eachra-bawn/servo
that referenced
this pull request
Aug 12, 2026
…wingNodeIterator (servo#47158) This uses inclusive_ancestors_unrooted instead of the rooted variant in the interior of UnrootedFollowingNodeIterator (in next_skipping_children_impl). Additionally, this PR relaxes the PartialEq for UnrootedDom to allow comparing UnrootedDom<'a,T> with UnrootedDom<'b, T>. This saves 0.4% of cpu in a slice on walrusaudio.com Testing: This does not have a specific testcase but inclusive_ancestors_unrooted is tested enough now to be equivalent to the rooted version. So this change should be equivalent. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…wingNodeIterator (servo#47158) This uses inclusive_ancestors_unrooted instead of the rooted variant in the interior of UnrootedFollowingNodeIterator (in next_skipping_children_impl). Additionally, this PR relaxes the PartialEq for UnrootedDom to allow comparing UnrootedDom<'a,T> with UnrootedDom<'b, T>. This saves 0.4% of cpu in a slice on walrusaudio.com Testing: This does not have a specific testcase but inclusive_ancestors_unrooted is tested enough now to be equivalent to the rooted version. So this change should be equivalent. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses inclusive_ancestors_unrooted instead of the rooted variant in the interior of UnrootedFollowingNodeIterator (in next_skipping_children_impl).
Additionally, this PR relaxes the PartialEq for UnrootedDom to allow comparing UnrootedDom<'a,T> with UnrootedDom<'b, T>.
This saves 0.4% of cpu in a slice on walrusaudio.com
Testing: This does not have a specific testcase but inclusive_ancestors_unrooted is tested enough now to be equivalent to the rooted version. So this change should be equivalent.