Repository navigation
script: Guard brotli transport stream with feature flag - #47197
Merged
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
Please check that this is how you should do domexception. |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jdm
approved these changes
Aug 12, 2026
Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
Brotli encoding is pretty costly time wise (it was developed with that in mind), so the code size kind of makes sense. And my ls only shows increments of Mb, so it might be that it is rounding. |
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
This guards brotli Transport Stream compression and decompression with a feature flag. If the feature flag is not enabled and transport stream is in brotli we throw a DOMException. This saves roughly 1Mb in production-stripped binary. Testing: The default is still to include brotli. Fixes: servo#47190 --------- Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guards brotli Transport Stream compression and decompression with a feature flag. If the feature flag is not enabled and transport stream is in brotli we throw a DOMException.
This saves roughly 1Mb in production-stripped binary.
Testing: The default is still to include brotli.
Fixes: #47190