Repository navigation
net: Use aws-lc-rs for subresource integrity instead of sha2 crate - #47214
Merged
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
sagudev
approved these changes
Aug 13, 2026
pull Bot
pushed a commit
to AKJUS/servo
that referenced
this pull request
Aug 14, 2026
Needs servo#47214 Subresource integrity was using strings compares at multiple points and needlessly used allocated strings. This uses an enum which allows us to enforce the priority with a PartialOrd. This removes one unit test for checking the order of the hash function as it is now not necessary. Testing: WPT test should test subresource integrity (https://github.com/Narfinger/servo/actions/runs/31698050312) Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…ervo#47214) This switches the subresource integrity system from the sha2 crate to aws-lc-rs. Aws-lc-rs is currently the backend for tls and tls anyway needs sha2. This saves us ~0.2Mb of binary size in production-stripped when webcrypto is disabled. Testing: SHA algorithms should be the same, no matter from which crate they come. Subresource integrity should have WPT tests. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Needs servo#47214 Subresource integrity was using strings compares at multiple points and needlessly used allocated strings. This uses an enum which allows us to enforce the priority with a PartialOrd. This removes one unit test for checking the order of the hash function as it is now not necessary. Testing: WPT test should test subresource integrity (https://github.com/Narfinger/servo/actions/runs/31698050312) Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the subresource integrity system from the sha2 crate to aws-lc-rs.
Aws-lc-rs is currently the backend for tls and tls anyway needs sha2.
This saves us ~0.2Mb of binary size in production-stripped when webcrypto is disabled.
Testing: SHA algorithms should be the same, no matter from which crate they come. Subresource integrity should have WPT tests.