script: Fix iframe name for initial navigation by TimvdLippe · Pull Request #47270 · servo/servo

TimvdLippe · 2026-08-16T09:30:48Z

During the initial load of an iframe, the name wasn't available yet. Now, we set the name immediately when creating the child navigable, following the spec.

Fixes #47259

Testing: new WPT passes

github-actions · 2026-08-16T09:31:06Z

🔨 Triggering try run (#31939245336) for Linux (WPT)

During the initial load of an iframe, the name wasn't available yet. Now, we set the name immediately when creating the child navigable, following the spec. Fixes servo#47259 Testing: new WPT passes Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>

servo-wpt-sync · 2026-08-16T09:34:25Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61969) with upstreamable changes.

servo-wpt-sync · 2026-08-16T09:38:02Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#61969).

github-actions · 2026-08-16T10:05:38Z

Test results for linux-wpt from try job (#31939245336):

Flaky unexpected result (43)

TIMEOUT [expected OK] /_webgl/conformance/textures/image_bitmap_from_blob/tex-2d-rgba-rgba-unsigned_byte.html
- NOTRUN [expected PASS] subtest: Overall test
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #53
- PASS [expected FAIL] subtest: WebGL test #55
- PASS [expected FAIL] subtest: WebGL test #57
- PASS [expected FAIL] subtest: WebGL test #59
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-14.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-16.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-17.html
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance2/attribs/gl-bindAttribLocation-aliasing-inactive.html
- NOTRUN [expected PASS] subtest: Overall test
CRASH [expected OK] /_webgl/conformance2/transform_feedback/transform_feedback.html
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = string
```
assert_false: expected false got true
```
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = blob
OK [expected TIMEOUT] /content-security-policy/inheritance/auxiliary-blank-document.html (#44821)
- PASS [expected TIMEOUT] subtest: window.open() inherits CSPs on transient about:blank.
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html (#45255)
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
ERROR [expected TIMEOUT] /css/css-sizing/responsive-iframe/responsive-iframe-allow-origins.html?container=subdomain,origin=cross,allowed=wildcard,expect=400 (#47268)
FAIL [expected PASS] /css/css-text-decor/text-underline-position-from-font-variable.html (#45615)
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- FAIL [expected PASS] subtest: moveBefore(): cross-origin iframe is preserved: remove new parent
```
assert_equals: iframe does not fire a second load event expected 1 but got 0
```
- FAIL [expected PASS] subtest: moveBefore(): cross-origin iframe is preserved: remove self
```
assert_equals: iframe does not fire a second load event expected 1 but got 0
```
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/gzip/big-gzip-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large gzip data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large gzip data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

CRASH [expected OK] /html/dom/elements/global-attributes/the-translate-attribute-012.html
OK /html/dom/render-blocking/remove-element-unblocks-rendering.optional.html
- PASS [expected FAIL] subtest: Render-blocking on script-inserted script is cancellable
- PASS [expected FAIL] subtest: Render-blocking on script-inserted module script is cancellable
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected PASS] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-permissions-policy.https.sub.html (#46803)
- PASS [expected TIMEOUT] subtest: Permissions-Policy header: autoplay * allows same-origin iframes.

OK /html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html (#46014)

FAIL [expected PASS] subtest: seek to currentTime

assert_array_equals: fired events lengths differ, expected array ["seeking", "timeupdate", "seeked"] length 3, got ["seeking", "timeupdate", "timeupdate", "seeked"] length 4

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK [expected TIMEOUT] /infrastructure/testdriver/click_nested.html (#43887)
- FAIL [expected NOTRUN] subtest: TestDriver click method with multiple windows and nested iframe
```
can't access property "document", child.frames[2] is undefined
```
ERROR [expected OK] /intersection-observer/v2/animated-opacity.html (#40827)
OK /mixed-content/tentative/autoupgrades/video-upgrade.https.sub.html (#41135)
- FAIL [expected PASS] subtest: Video of other host autoupgraded
```
assert_equals: Length. Other host expected 1 but got Infinity
```
OK /paint-timing/fcp-only/fcp-svg.html (#45878)
- PASS [expected FAIL] subtest: First contentful paint fires when SVG becomes contentful.
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#44693)
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK /pointerevents/compat/pointerevent_touch_target_after_pointerdown_target_removed.tentative.html (#42813)
- PASS [expected FAIL] subtest: After a pointerdown listener moves the target to different position, touch events should be fired on the pointerdown target, but pointer events should be fired on the pointerdown target parent
- PASS [expected FAIL] subtest: After a pointerdown listener moves the target to different position, touchmove event should be fired on the pointerdown target parent

OK /pointerevents/pointerevent_pointercapture_in_frame.html?pen (#45536)

FAIL [expected PASS] subtest:

Test penpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.

assert_array_equals: Received events: innerFrame received pointerdown,innerFrame received pointermove,innerFrame received pointerup,innerFrame received lostpointercapture lengths differ, expected array ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup"] length 3, got ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup", "innerFrame received lostpointercapture"] length 4

OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)

FAIL [expected PASS] subtest:

Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.

assert_array_equals: Received events: innerFrame received pointerdown,innerFrame received pointermove,innerFrame received pointerup,innerFrame received lostpointercapture lengths differ, expected array ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup"] length 3, got ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup", "innerFrame received lostpointercapture"] length 4

OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
OK /touch-events/hover-state-caused-by-compatibility-mouse-events.tentative.html (#46277)
- PASS [expected FAIL] subtest: The compatibility mouse events should set :hover: The compatibility mouse events should be fired
- PASS [expected FAIL] subtest: The compatibility mouse events should set :hover, but shouldn't be preserved after the target is replaced: The compatibility mouse events should be fired
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected OK] /uievents/mouse/mousemove_prevent_default_action.html

Stable unexpected results that are known to be intermittent (14)

OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-weight: '399' should prefer '200 300' over '400'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
ERROR [expected OK] /css/css-sizing/responsive-iframe/responsive-iframe-allow-origins.html?container=subdomain,origin=same,allowed=wildcard,expect=400 (#47268)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#44099)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by submitButton.click()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20const%20button%20%3D%20document.createElement(%22button%22)%3B%0A%20%20%20%20button.type%20%3D%20%22submit%22%3B%0A%20%20%20%20form.append(button)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20button.click()%3B%0A%20%20"

TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- PASS [expected FAIL] subtest: traversing history must also traverse hash changes
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-permissions-policy.https.sub.html (#46805)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-permissions-policy.https.sub.html (#46012, #46804)
- TIMEOUT [expected FAIL] subtest: Permissions-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
TIMEOUT /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
- TIMEOUT [expected PASS] subtest: <body><?xml>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?xml-stylesheet>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?XML>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?XML-stylesheet>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?xML>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?xml-STYLesheet>
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: <body><?1st-place>
```
Test timed out
```
TIMEOUT [expected OK] /html/syntax/parsing/html5lib_write_single.html?file=processing-instructions (#46206)
- TIMEOUT [expected FAIL] subtest: <body><?_prefix data>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?_x132>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?_x132 data>
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: <body><?_-_>
```
Test timed out
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin video should get upgraded even if CORS is set
```
assert_equals: Length. Other host expected 1 but got Infinity
```
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (script)
OK /sanitizer-api/sanitizer-inert-document.html (#45260)
- FAIL [expected PASS] subtest: Test whether setHTML loads the image.
```
promise_test: Unhandled rejection with value: "The server observed a request. It shouldn't have."
```
- PASS [expected FAIL] subtest: Test whether setHTMLUnsafe loads the image.
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- TIMEOUT [expected PASS] subtest: Navigate a frame via area with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```

github-actions · 2026-08-16T10:05:49Z

✨ Try run (#31939245336) succeeded.

jdm

Good find!

servo-wpt-sync · 2026-08-16T16:21:23Z

⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#61969). Please address any CI issues and try to merge manually.

During the initial load of an iframe, the name wasn't available yet. Now, we set the name immediately when creating the child navigable, following the spec. Fixes servo#47259 Testing: new WPT passes Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net>

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Aug 16, 2026

TimvdLippe requested a review from gterzian as a code owner August 16, 2026 09:30

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 16, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Aug 16, 2026

TimvdLippe mentioned this pull request Aug 16, 2026

IFrame name attribute is not reflected in initial cross-origin iframe navigation #47259

Closed

TimvdLippe force-pushed the fix-iframe-name-during-initial-navigation branch from 02510ad to a272e93 Compare August 16, 2026 09:32

servo-wpt-sync mentioned this pull request Aug 16, 2026

script: Fix iframe name for initial navigation web-platform-tests/wpt#61969

Merged

jdm approved these changes Aug 16, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 16, 2026

TimvdLippe added this pull request to the merge queue Aug 16, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2026

Merged via the queue into servo:main with commit 80b2c05 Aug 16, 2026
33 checks passed

TimvdLippe deleted the fix-iframe-name-during-initial-navigation branch August 16, 2026 16:19

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2026

Navigation Menu

Repository navigation

script: Fix iframe name for initial navigation - #47270

script: Fix iframe name for initial navigation#47270
TimvdLippe merged 1 commit into
servo:mainfrom
TimvdLippe:fix-iframe-name-during-initial-navigation

TimvdLippe commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

jdm left a comment

Uh oh!

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TimvdLippe commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

github-actions Bot commented Aug 16, 2026

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

servo-wpt-sync commented Aug 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants