Repository navigation
constellation: Queue session history traversals - #47293
Merged
Merged
Conversation
mrobinson
force-pushed
the
history-traversal
branch
from
August 17, 2026 12:44
92c5b4d to
8c45069
Compare
|
🔨 Triggering try run (#32031410554) for Linux (WPT) |
mrobinson
force-pushed
the
history-traversal
branch
from
August 17, 2026 12:48
8c45069 to
c0e3f75
Compare
|
Test results for linux-wpt from try job (#32031410554): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#32031410554) succeeded. |
Contributor
|
Can we wait until #46975 is merged, or at least merge these two with a couple of days in between? Both are impactful changes for navigation and to minimise impact on CI stability, I think it's good to be cautious. |
Member
Author
Sure. This is ready to review and merge now, so it could be merged now or later (if #46975 will be merged soon). |
|
🔨 Triggering try run (#32047871962) for Linux (WPT) |
jdm
approved these changes
Aug 17, 2026
jdm
left a comment
Member
There was a problem hiding this comment.
This is great! Thanks for tackling this!
| browsing_context_id: BrowsingContextId, | ||
| new_reloader: NeedsToReload, | ||
| ) { | ||
| ) -> Option<PipelineId> { |
Member
There was a problem hiding this comment.
Let's document what this return value means.
Member
Author
There was a problem hiding this comment.
Thanks for the review. I've added documentation for this now.
|
✨ Try run (#32047871962) succeeded. |
Instead of running history traversals (moving backward and forward in the session history) immediately, only run each traversal after the previous one has finished. Traversals may not finish immediately if a page needs to be reloaded due to being a sufficient distance away in the back-forward list to not be cached or because an `unload` handler ran. This fixes issues with intermittency when running history navigation tests. Previously, history traversals were run immediately (instead of being queued) which could lead to nondeterminate navigation outcomes. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
history-traversal
branch
from
August 18, 2026 13:27
c0e3f75 to
a8c60a8
Compare
mrobinson
enabled auto-merge
August 18, 2026 13:27
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Instead of running history traversals (moving backward and forward in the session history) immediately, only run each traversal after the previous one has finished. Traversals may not finish immediately if a page needs to be reloaded due to being a sufficient distance away in the back-forward list to not be cached or because an `unload` handler ran. This fixes issues with intermittency when running history navigation tests. Previously, history traversals were run immediately (instead of being queued) which could lead to nondeterminate navigation outcomes. Testing: This should eliminate test flakiness on the CI. Fixes: servo#21383. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running history traversals (moving backward and forward in
the session history) immediately, only run each traversal after the
previous one has finished. Traversals may not finish immediately if a
page needs to be reloaded due to being a sufficient distance away in the
back-forward list to not be cached or because an
unloadhandler ran.This fixes issues with intermittency when running history navigation
tests. Previously, history traversals were run immediately (instead of
being queued) which could lead to nondeterminate navigation outcomes.
Testing: This should eliminate test flakiness on the CI.
Fixes: #21383.