Repository navigation
servoshell: Update deprecated keycodes - #47330
Merged
Merged
Conversation
Fixes: servo#41306 Signed-off-by: eachra-bawn <mulhalloisin@gmail.com>
Member
|
@eachra-bawn Do you think you can write a bit of text into the PR description describing the difference between these two values and why this change is correct? It will really help both reviewers and people looking at this change in the future. |
Contributor
Author
|
Sorry about that. Fixed now. |
mrobinson
enabled auto-merge
August 18, 2026 12:15
Member
|
Thanks! |
TimvdLippe
approved these changes
Aug 18, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Approving on Martins behalf
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
This updates servoshell's key event interpretation so that the macOS Command key and the Windows Logo key correspond to 'Meta'. Previously, this was causing servoshell to interpret these as 'Super', which is unlike other browsers' behaviour such as Chrome, which interpret these keys as 'Meta'. Here is the documentation from winit regarding the 'Super' key: https://docs.rs/winit/latest/winit/keyboard/enum.NamedKey.html#variant.Super Testing: servoshell does not have testing at this layer. Fixes: servo#41306 Signed-off-by: eachra-bawn <mulhalloisin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates servoshell's key event interpretation so that the macOS Command key and the Windows Logo key correspond to 'Meta'. Previously, this was causing servoshell to interpret these as 'Super', which is unlike other browsers' behaviour such as Chrome, which interpret these keys as 'Meta'.
Here is the documentation from winit regarding the 'Super' key:
https://docs.rs/winit/latest/winit/keyboard/enum.NamedKey.html#variant.Super
Testing: servoshell does not have testing at this layer.
Fixes: #41306