Skip to content

layout: Reduce allocation when constructing InnerOrOuterTextItem - #47343

Merged
jdm merged 1 commit into
servo:mainfrom
yezhizhen:more-cow
Aug 19, 2026
Merged

jdm merged 1 commit into
servo:mainfrom
yezhizhen:more-cow

Conversation

@yezhizhen

Copy link
Copy Markdown
Member

Make InnerOrOuterTextItem::Text takes Cow instead of owned String.

Testing: No behaviour change.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 18, 2026

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 19, 2026
@jdm
jdm added this pull request to the merge queue Aug 19, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 19, 2026
Merged via the queue into servo:main with commit 09a6a4f Aug 19, 2026
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 19, 2026
@yezhizhen
yezhizhen deleted the more-cow branch August 19, 2026 05:08
RichardTjokroutomo pushed a commit to RichardTjokroutomo/servo that referenced this pull request Oct 6, 2026
…ervo#47343)

Make `InnerOrOuterTextItem::Text` takes Cow instead of owned String.

Testing: No behaviour change.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants