Repository navigation
ohos: Better keyboard support - #47359
Merged
Merged
Conversation
For physical keyboards we need to translate the OH KeyEventCode into a KeyEvent with a Unicode character, taking into account keyboard state (like shift or caps lock). Since OH still doesn't have a keyboard layout API, this is greatly simplified due to only needing to support US keyboard layout. The actual conversion is handled in the xcomponent-sys crate. This now allows typing with a real keyboard to work as expected. (Limited testing) Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Narfinger
requested changes
Aug 19, 2026
Narfinger
approved these changes
Aug 19, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
For physical keyboards we need to translate the OH KeyEventCode into a KeyEvent with a Unicode character, taking into account keyboard state (like shift or caps lock). Since OH still doesn't have a keyboard layout API, this is greatly simplified due to only needing to support US keyboard layout. The actual conversion is handled in the xcomponent-sys crate. This now allows typing with a real (US-layout) keyboard to work as expected on OpenHarmony. Testing: This is not covered by any automatic tests, and I also didn't find an API that allows simulating raw keyboard events (`hdc shell uinput` seems to behave differently to a raw keyboard). This was manually tested on a dayu-200 developer board with a keyboard attached. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For physical keyboards we need to translate the OH KeyEventCode into a KeyEvent with a Unicode character, taking into account keyboard state (like shift or caps lock).
Since OH still doesn't have a keyboard layout API, this is greatly simplified due to only needing to support US keyboard layout. The actual conversion is handled in the xcomponent-sys crate.
This now allows typing with a real (US-layout) keyboard to work as expected on OpenHarmony.
Testing: This is not covered by any automatic tests, and I also didn't find an API that allows simulating raw keyboard events (
hdc shell uinputseems to behave differently to a raw keyboard). This was manually tested on a dayu-200 developer board with a keyboard attached.