Skip to content

script: Implement indent command - #47416

Merged
TimvdLippe merged 2 commits into
servo:mainfrom
Psychpsyo:execCommand-indent
Aug 21, 2026
Merged

TimvdLippe merged 2 commits into
servo:mainfrom
Psychpsyo:execCommand-indent

Conversation

@Psychpsyo

Copy link
Copy Markdown
Contributor

Implements the "indent" command for contenteditable elements.

Testing: More passes

@Psychpsyo
Psychpsyo requested a review from gterzian as a code owner August 21, 2026 01:24
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 21, 2026
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again chugging through these. Some minor comments, but overall LGTM

Comment thread components/script/dom/execcommand/contenteditable/element.rs Outdated
Comment thread components/script/dom/execcommand/contenteditable/element.rs
Comment thread components/script/dom/execcommand/commands/indent.rs Outdated
Comment thread components/script/dom/execcommand/commands/indent.rs Outdated
Comment thread components/script/dom/execcommand/commands/indent.rs
Comment thread components/script/dom/execcommand/commands/indent.rs Outdated
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 21, 2026
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 21, 2026
@Psychpsyo

Copy link
Copy Markdown
Contributor Author

Great work again chugging through these. Some minor comments, but overall LGTM

Thanks for reviewing, I've now done all that. Also got us a couple more test passes.

@TimvdLippe
TimvdLippe added this pull request to the merge queue Aug 21, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 21, 2026
Merged via the queue into servo:main with commit 3081b14 Aug 21, 2026
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 21, 2026
RichardTjokroutomo pushed a commit to RichardTjokroutomo/servo that referenced this pull request Oct 6, 2026
Implements the "indent" command for contenteditable elements.

Testing: More passes

---------

Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants