Repository navigation
script: Align live range update steps with specification - #47425
Merged
Merged
Conversation
|
🔨 Triggering try run (#32481987158) for Linux (WPT) |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#62112) with upstreamable changes. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#62112) title and body. |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#62112). |
|
Test results for linux-wpt from try job (#32481987158): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (13)
|
|
✨ Try run (#32481987158) succeeded. |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#62112). |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#62112) title and body. |
SimonSapin
reviewed
Aug 25, 2026
mrobinson
commented
Aug 25, 2026
mrobinson
left a comment
Member
Author
There was a problem hiding this comment.
@SimonSapin Thanks for the review! I think I've addressed all of your concerns.
SimonSapin
approved these changes
Aug 25, 2026
This change reworks the live range update steps that show up in various places in the specification so that they match what the specification says. Now updates to live ranges uses the existing `set_start` and `set_end` APIs which simplify the code greatly as they already handle updating the `Node`'s live range list. This is preparation work for adding a new live-ish range type for selections (which will have a few different requirements than a real DOM live range). Improvements to spec compliance of `Node#normalize()`: - Instead of issuing one mutation record per merged node only issue a single one. - The change to the preserved node's data happens before the merged nodes' removal. - Indices for live range updates would be stale when merging more than two nodes. Notes on performance: - This switches to accessing a rooted `SmallVec` of live ranges per-node. In cases where a node has 4 or fewer live ranges, this will not allocate, otherwise this adds a new vector allocation for an edge case. - The amount of rooting should be unchanged as the old code had to root all accessed `Range`'s anyway. - In some cases we avoid calculating node indices where they were before using `LazyCell`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
enabled auto-merge
August 25, 2026 15:45
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#62112). |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#62112). |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
This change reworks the live range update steps that show up in various places in the specification so that they match what the specification says. Now updates to live ranges use the existing `set_start` and `set_end` APIs which simplify the code greatly as they already handle updating the `Node`'s live range list. This is preparation work for adding a new live-ish range type for selections (which will have a few different requirements than a real DOM live range). Improvements to spec compliance of `Node#normalize()`: - Instead of issuing one mutation record per merged node only issue a single one. - The change to the preserved node's data happens before the merged nodes' removal. - Indices for live range updates would be stale when merging more than two nodes. Notes on performance: - This switches to accessing a rooted `SmallVec` of live ranges per-node. In cases where a node has 4 or fewer live ranges, this will not allocate, otherwise this adds a new vector allocation for an edge case. - The amount of rooting should be unchanged as the old code had to root all accessed `Range`'s anyway. - In some cases we avoid calculating node indices where they were before using `LazyCell`. Testing: This change adds a new WPT test. --------- Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
This change reworks the live range update steps that show up in various places in the specification so that they match what the specification says. Now updates to live ranges use the existing `set_start` and `set_end` APIs which simplify the code greatly as they already handle updating the `Node`'s live range list. This is preparation work for adding a new live-ish range type for selections (which will have a few different requirements than a real DOM live range). Improvements to spec compliance of `Node#normalize()`: - Instead of issuing one mutation record per merged node only issue a single one. - The change to the preserved node's data happens before the merged nodes' removal. - Indices for live range updates would be stale when merging more than two nodes. Notes on performance: - This switches to accessing a rooted `SmallVec` of live ranges per-node. In cases where a node has 4 or fewer live ranges, this will not allocate, otherwise this adds a new vector allocation for an edge case. - The amount of rooting should be unchanged as the old code had to root all accessed `Range`'s anyway. - In some cases we avoid calculating node indices where they were before using `LazyCell`. Testing: This change adds a new WPT test. --------- Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reworks the live range update steps that show up in various
places in the specification so that they match what the specification
says. Now updates to live ranges use the existing
set_startandset_endAPIs which simplify the code greatly as they already handleupdating the
Node's live range list. This is preparation work foradding a new live-ish range type for selections (which will have a few
different requirements than a real DOM live range).
Improvements to spec compliance of
Node#normalize():single one.
nodes' removal.
than two nodes.
Notes on performance:
SmallVecof live rangesper-node. In cases where a node has 4 or fewer live ranges, this will
not allocate, otherwise this adds a new vector allocation for an
edge case.
root all accessed
Range's anyway.before using
LazyCell.Testing: This change adds a new WPT test.