Skip to content

script: Clarify various error messages - #47430

Merged
jdm merged 5 commits into
servo:mainfrom
jdm:better-errors
Aug 21, 2026
Merged

jdm merged 5 commits into
servo:mainfrom
jdm:better-errors

Conversation

@jdm

@jdm jdm commented Aug 21, 2026

Copy link
Copy Markdown
Member

Testing: We don't test the contents of error messages.

@jdm
jdm requested a review from gterzian as a code owner August 21, 2026 14:41
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 21, 2026
Comment thread components/script/dom/document/documentorshadowroot.rs Outdated
jdm added 5 commits August 21, 2026 11:16
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 21, 2026
@jdm
jdm enabled auto-merge August 21, 2026 15:24
@jdm
jdm added this pull request to the merge queue Aug 21, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 21, 2026
Merged via the queue into servo:main with commit bcee6be Aug 21, 2026
33 checks passed
@jdm
jdm deleted the better-errors branch August 21, 2026 16:45
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 21, 2026
RichardTjokroutomo pushed a commit to RichardTjokroutomo/servo that referenced this pull request Oct 6, 2026
Testing: We don't test the contents of error messages.

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants