Repository navigation
script: Implement insertLineBreak command - #47445
Merged
Merged
Conversation
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
TimvdLippe
reviewed
Aug 22, 2026
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
TimvdLippe
approved these changes
Aug 23, 2026
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Aug 24, 2026
{"fail_fast": false, "matrix": [{"name": "Linux (Production, WPT)", "workflow": "linux", "wpt": true, "profile": "production", "unit_tests": false, "devtools_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "capi": false, "build_args": "", "wpt_args": "_webgpu --processes 1", "number_of_wpt_chunks": 20}]}
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Implement the `insertLineBreak` command for contenteditable stuff. Testing: More WPT passes PS: Yes, I do still plan to get to writing `is_collapsed_line_break` at some point. But for now, I want at least something implemented for every editing command. (at least all the ones that are relevant to keyboard input so that once regular DOM content becomes selectable, we can put in a thing that calls them upon user key presses. :) ) --------- Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the
insertLineBreakcommand for contenteditable stuff.Testing: More WPT passes
PS: Yes, I do still plan to get to writing
is_collapsed_line_breakat some point.But for now, I want at least something implemented for every editing command. (at least all the ones that are relevant to keyboard input so that once regular DOM content becomes selectable, we can put in a thing that calls them upon user key presses. :) )