Repository navigation
script: Fix the conversion behavior of RsaKeyGenParams - #47453
Merged
Merged
Conversation
In WebCrypto API specification, the modulusLength member of the RsaKeyGenParams dictionary has the [EnforceRange] extended attribute. We mistakenly set the conversion behavior as `ConversionBehavior::Default` in our code. We change it back to `ConversionBehavior::EnforceRange`. Spec: https://w3c.github.io/webcrypto/#RsaKeyGenParams-dictionary Testing: Pass more WPT tests. Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
TimvdLippe
approved these changes
Aug 23, 2026
TimvdLippe
enabled auto-merge
August 23, 2026 05:16
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
In WebCrypto API specification, the modulusLength member of the RsaKeyGenParams dictionary has the [EnforceRange] extended attribute. We mistakenly set the conversion behavior as `ConversionBehavior::Default` in our code. We change it back to `ConversionBehavior::EnforceRange`. Spec: https://w3c.github.io/webcrypto/#RsaKeyGenParams-dictionary Testing: Pass more WPT tests. Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WebCrypto API specification, the modulusLength member of the RsaKeyGenParams dictionary has the [EnforceRange] extended attribute. We mistakenly set the conversion behavior as
ConversionBehavior::Defaultin our code. We change it back toConversionBehavior::EnforceRange.Spec: https://w3c.github.io/webcrypto/#RsaKeyGenParams-dictionary
Testing: Pass more WPT tests.