Repository navigation
android: Remove constructor for XML layouts - #47491
Merged
Merged
Conversation
Signed-off-by: veyndan <veyndan@gmail.com>
jdm
approved these changes
Aug 24, 2026
jdm
enabled auto-merge
August 24, 2026 19:02
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
The constructor with the `AttributeSet` argument is needed for XML layouts. Since we're moving towards a Compose UI layout per servo#33742, we don't need this constructor any more, and removing it makes it explicit that this is no longer supported. Testing: There are no automated tests for Android. Fixes: Part of servo#33742. Signed-off-by: veyndan <veyndan@gmail.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
The constructor with the `AttributeSet` argument is needed for XML layouts. Since we're moving towards a Compose UI layout per servo#33742, we don't need this constructor any more, and removing it makes it explicit that this is no longer supported. Testing: There are no automated tests for Android. Fixes: Part of servo#33742. Signed-off-by: veyndan <veyndan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor with the
AttributeSetargument is needed for XML layouts. Since we're moving towards a Compose UI layout per #33742, we don't need this constructor any more, and removing it makes it explicit that this is no longer supported.Testing: There are no automated tests for Android.
Fixes: Part of #33742.