Repository navigation
script: Reduce String allocation of JS API of fetch Headers - #47530
Merged
Merged
Conversation
yezhizhen
commented
Aug 26, 2026
| }; | ||
|
|
||
| valid_name = valid_name.to_lowercase(); | ||
| valid_name.make_ascii_lowercase(); |
Member
Author
There was a problem hiding this comment.
This is equivalent because we have validated with
servo/components/script_bindings/str.rs
Line 147 in c4d8c0f
Contributor
There was a problem hiding this comment.
I think we should have at least a comment here. Something like: "Tokens are always ascii".
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Narfinger
approved these changes
Aug 26, 2026
Narfinger
enabled auto-merge
August 26, 2026 09:54
yezhizhen
added a commit
to yezhizhen/servo
that referenced
this pull request
Aug 29, 2026
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We modify validated name in-place instead.
Testing: Covered by existing tests. Tho I have not tested as it's trivial.