Repository navigation
net: Instead of Duration use ApproxDuration - #47541
Merged
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Member
|
"13.93MiB for the cache to 13.93MiB." did you mean to write something else here? |
Contributor
Author
|
Fixed. |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
This changes the Duration in CachedResources to ApproxDuration. This saves us a couple of bytes per CachedResources as ApproxDuration only stores the seconds (and Duration has nanosecond precision). This adds up and on a simple load of thomann.de we go from 13.95MiB for the cache to 13.93MiB. For more browsing this gap will only get better. The spec only cares about second precision. Testing: As the spec only cares about seconds precision and we never used nanosecond precision, the nanosecond Duration part was always zero. Hence, this should not have any effects. --------- Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
This changes the Duration in CachedResources to ApproxDuration. This saves us a couple of bytes per CachedResources as ApproxDuration only stores the seconds (and Duration has nanosecond precision). This adds up and on a simple load of thomann.de we go from 13.95MiB for the cache to 13.93MiB. For more browsing this gap will only get better. The spec only cares about second precision. Testing: As the spec only cares about seconds precision and we never used nanosecond precision, the nanosecond Duration part was always zero. Hence, this should not have any effects. --------- Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the Duration in CachedResources to ApproxDuration.
This saves us a couple of bytes per CachedResources as ApproxDuration only stores the seconds (and Duration has nanosecond precision).
This adds up and on a simple load of thomann.de we go from 13.95MiB for the cache to 13.93MiB. For more browsing this gap will only get better.
The spec only cares about second precision.
Testing: As the spec only cares about seconds precision and we never used nanosecond precision, the nanosecond Duration part was always zero. Hence, this should not have any effects.