Repository navigation
net: Allow * in Access-Control-Allow-Headers to cover authorization - #47600
Conversation
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
|
Should you file something with the spec? |
Thanks! Found it: whatwg/fetch#1919 |
Narfinger
left a comment
There was a problem hiding this comment.
I think we should allow this but I kind of don't want to merge this on my own.
TimvdLippe
left a comment
There was a problem hiding this comment.
Can you send a PR to the spec with an updated text and then use that text here? Additionally, let's update the relevant WPT tests that started failing to instead expect the behavior of browsers. Then, let's ask for consensus on the issue you linked that the updated spec text is accepted and the tests are asserting the correct behavior. Once that's settled, I would be comfortable merging this PR.
|
|
And 5. The very original issue whatwg/fetch#1278 is open for 5 years. If it's not settled yet, it is difficult for me alone to reach the conclusive spec text fix, assuming I can resolve IPR issue someday. |
|
Seems like Anne pinged Chrome folks in WhatWG chat: https://matrix.to/#/!AGetWbsMpFPdSgUrbs:matrix.org/$f3_ETYVhzovvCkMW0mgYFctXNX_rimXqamHyoXWTQro?via=matrix.org&via=mozilla.org&via=igalia.com Let's wait on their resolution and then decide how to proceed forwards. |
These can take months/years assuming it finally happens. This blocks many sites such as https://bsky.app/. Maybe you are not happy with wpt passing rate, but at the end of the day, it is actual web compatibility that matters. And some people do use Servo to access websites. I think we should land this like other browsers. If there is real progress on the spec, I'm happy to adapt then. |
|
I am not proposing we wait months/years, that indeed is unreasonable. My proposal is as follows:
Does that sound reasonable to you? |
|
I find this conversation uncomfortable, if this is called conversation at all. I'm only receiving imperatives from very beginning and specific timelines now. |
…ervo#47600) [Zulip chat](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/.22authorization.22.20should.20not.20be.20covered.20by.20the.20wildcard.20symbol/with/619720785). According to MDN/Spec/WPT tests, this should not be allowed. However, all browsers allow it, and fail these WPT tests. This is discovered when visiting some websites but failed with "CORS Authorization check". Testing: Updated WPT. All other browsers fail these specific tests. [Test1](https://wpt.fyi/results/fetch/api/cors/cors-preflight.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) [Test2](https://wpt.fyi/results/fetch/api/cors/cors-preflight-star.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight-star.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) [Test3](https://wpt.fyi/results/fetch/api/cors/cors-preflight-cache.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight-cache.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) --- Spec issue: whatwg/fetch#1919 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
…ervo#47600) [Zulip chat](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/.22authorization.22.20should.20not.20be.20covered.20by.20the.20wildcard.20symbol/with/619720785). According to MDN/Spec/WPT tests, this should not be allowed. However, all browsers allow it, and fail these WPT tests. This is discovered when visiting some websites but failed with "CORS Authorization check". Testing: Updated WPT. All other browsers fail these specific tests. [Test1](https://wpt.fyi/results/fetch/api/cors/cors-preflight.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) [Test2](https://wpt.fyi/results/fetch/api/cors/cors-preflight-star.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight-star.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) [Test3](https://wpt.fyi/results/fetch/api/cors/cors-preflight-cache.any.html?q=%2Ffetch%2Fapi%2Fcors%2Fcors-preflight-cache.any.html&run_id=5120815879421952&run_id=6266127830482944&run_id=4925178911129600&run_id=6310660769316864) --- Spec issue: whatwg/fetch#1919 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Zulip chat.
According to MDN/Spec/WPT tests, this should not be allowed.
However, all browsers allow it, and fail these WPT tests.
This is discovered when visiting some websites but failed with "CORS Authorization check".
Testing: Updated WPT. All other browsers fail these specific tests.
Test1
Test2
Test3
Spec issue: whatwg/fetch#1919