Repository navigation
gstreamer: Use more lenient MIME type parser for canPlayType. - #47641
Merged
Merged
Conversation
jdm
commented
Aug 30, 2026
| expected: PRECONDITION_FAILED | ||
|
|
||
| [audio/ogg with and without codecs] | ||
| [audio/mp4 with and without codecs] |
Member
Author
There was a problem hiding this comment.
A few of these new failures will be fixed by my forthcoming fix for #46259.
TimvdLippe
approved these changes
Aug 30, 2026
| gstreamer-video = { workspace = true } | ||
| gstreamer-webrtc = { workspace = true } | ||
| log = { workspace = true } | ||
| mime = { workspace = true } |
Contributor
There was a problem hiding this comment.
We use the mime crate in other places as well. Should we in general start replacing it with data-url?
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
jdm
enabled auto-merge
August 30, 2026 05:12
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 30, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…47641) The tests that now pass were using a MIME type like "audio/mp4;codecs", for which the mime crate returns an error because it expects a = following each MIME type parameter name. The data-url crate's MIME type parser handles this the same way as other browsers; there's a parameter named `codecs` with an empty value. Testing: New passing tests. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…47641) The tests that now pass were using a MIME type like "audio/mp4;codecs", for which the mime crate returns an error because it expects a = following each MIME type parameter name. The data-url crate's MIME type parser handles this the same way as other browsers; there's a parameter named `codecs` with an empty value. Testing: New passing tests. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests that now pass were using a MIME type like "audio/mp4;codecs", for which the mime crate returns an error because it expects a = following each MIME type parameter name. The data-url crate's MIME type parser handles this the same way as other browsers; there's a parameter named
codecswith an empty value.Testing: New passing tests.