Repository navigation
android: Move servo[Args][Log] to constructor - #47644
Merged
Merged
Conversation
Signed-off-by: veyndan <veyndan@gmail.com>
servo[Args][Logs] to constructorservo[Args][Log] to constructor
jdm
approved these changes
Aug 30, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
`setServoArgs` currently gives the false impression that it can be invoked after the surface has been created and update the engine with it's arguments. This isn't the case though, since calling `setServoArgs` is a no-op after the surface has been created. It's not possible yet to move `experimentalMode` to the constructor yet, since the argument is calculated assuming an instance of `ServoView` is present, getting us into the chicken and the egg problem. The method has been renamed to `setExperimentalModeInit` for now to make clear that this is only useful to set during the initialisation phase of the surface. Moving `experimentalMode` to the constructor will be addressed in a follow-up PR though, so this clarity is in the type system instead of a function name. Testing: There are no automated tests for Android. Signed-off-by: veyndan <veyndan@gmail.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
`setServoArgs` currently gives the false impression that it can be invoked after the surface has been created and update the engine with it's arguments. This isn't the case though, since calling `setServoArgs` is a no-op after the surface has been created. It's not possible yet to move `experimentalMode` to the constructor yet, since the argument is calculated assuming an instance of `ServoView` is present, getting us into the chicken and the egg problem. The method has been renamed to `setExperimentalModeInit` for now to make clear that this is only useful to set during the initialisation phase of the surface. Moving `experimentalMode` to the constructor will be addressed in a follow-up PR though, so this clarity is in the type system instead of a function name. Testing: There are no automated tests for Android. Signed-off-by: veyndan <veyndan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setServoArgscurrently gives the false impression that it can be invoked after the surface has been created and update the engine with it's arguments. This isn't the case though, since callingsetServoArgsis a no-op after the surface has been created.It's not possible yet to move
experimentalModeto the constructor yet, since the argument is calculated assuming an instance ofServoViewis present, getting us into the chicken and the egg problem.The method has been renamed to
setExperimentalModeInitfor now to make clear that this is only useful to set during the initialisation phase of the surface. MovingexperimentalModeto the constructor will be addressed in a follow-up PR though, so this clarity is in the type system instead of a function name.Testing: There are no automated tests for Android.