Repository navigation
script: Introduce unrooted variant of GPUCanvasConfiguration - #47650
Merged
Merged
Conversation
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
sagudev
approved these changes
Aug 30, 2026
sagudev
reviewed
Aug 30, 2026
|
|
||
| /// <https://gpuweb.github.io/gpuweb/#dom-gpucanvascontext-configure> | ||
| fn Configure(&self, configuration: &GPUCanvasConfiguration) -> Fallible<()> { | ||
| fn Configure(&self, configuration: &RootedGPUCanvasConfiguration) -> Fallible<()> { |
Member
There was a problem hiding this comment.
off-topic: why does codegen even generate rooted stuff. What if we would make all unrooted and then use rooted macro for rooting where needed.
Member
There was a problem hiding this comment.
It's like that because the dictionary stuff was written at least 10 years before I added support for rooting arbitrary rust types with the rooted macro :p
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…#47650) Testing: It compiles Part of servo#39139 Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…#47650) Testing: It compiles Part of servo#39139 Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Gae24
added a commit
to Gae24/servo
that referenced
this pull request
Nov 2, 2026
servo#47650)" This reverts commit 6cef732.
Gae24
added a commit
to Gae24/servo
that referenced
this pull request
Nov 3, 2026
servo#47650)" This reverts commit 6cef732.
Gae24
added a commit
to Gae24/servo
that referenced
this pull request
Nov 4, 2026
servo#47650)" This reverts commit 6cef732.
Gae24
added a commit
to Gae24/servo
that referenced
this pull request
Nov 5, 2026
servo#47650)" This reverts commit 6cef732.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: It compiles
Part of #39139