Repository navigation
script: Reset click count when touchend doesn't synthesize mouse events - #48699
Merged
Merged
Conversation
TimvdLippe
approved these changes
Oct 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
hhhwsqhhh
pushed a commit
to hhhwsqhhh/servo
that referenced
this pull request
Oct 12, 2026
…ts (servo#48699) `/touch-events/mouseevents-after-touchend.tentative.html` reveals an general issue that the side-effect of previous subtests remain: a touch sequence that doesn't synthesize compatibility mouse events doesn't reset click count. That may turn two unrelated quick tap/two finger gesture into weird results. Testing: `/touch-events/mouseevents-after-touchend.tentative.html` no longer intermittent. Fixes: servo#46497 Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/touch-events/mouseevents-after-touchend.tentative.htmlreveals an general issue that the side-effect of previous subtests remain: a touch sequence that doesn't synthesize compatibility mouse events doesn't reset click count.That may turn two unrelated quick tap/two finger gesture into weird results.
Testing:
/touch-events/mouseevents-after-touchend.tentative.htmlno longer intermittent.Fixes: #46497