Repository navigation
[Process] Fix waitUntil() missing output read by its own status updates - #66620
Merged
nicolas-grekas merged 1 commit intoOct 5, 2026
Merged
Conversation
KalimeroMK
force-pushed
the
fix-process-waituntil-windows
branch
3 times, most recently
from
October 4, 2026 20:19
32d3176 to
6308441
Compare
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
xabbuh and
yceruto
as code owners
October 5, 2026 04:33
nicolas-grekas
force-pushed
the
fix-process-waituntil-windows
branch
from
October 5, 2026 04:34
6308441 to
6bfc8d6
Compare
Member
|
I rebased on 6.4, where the bug is too, and updated the PR: deterministic tests, the callback restored on every exit path but not after |
waitUntil() reads the pipes through updateStatus() before its loop, and through isRunning() on each iteration on Windows. That output only reached the callback given to start(), so waitUntil() could miss the line it waits for. Its callback now receives that output too, and the callback of start() is restored on every exit path, unless close() released it.
nicolas-grekas
force-pushed
the
fix-process-waituntil-windows
branch
from
October 5, 2026 04:43
6bfc8d6 to
e727b09
Compare
Member
|
Thank you @KalimeroMK. |
KalimeroMK
added a commit
to KalimeroMK/KalimeroMK
that referenced
this pull request
Oct 5, 2026
This was referenced Oct 14, 2026
Merged
Merged
Merged
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitUntil()reads the pipes throughupdateStatus()before its loop, and throughisRunning()on each iteration on Windows. That output only reached the callback given tostart(), sowaitUntil()could miss the line it waits for: it then returnedfalse, or waited forever when the child stayed silent. Its callback now receives that output too.Merge-up to 7.4: drop the
#[Group('transient-on-windows')]attribute oftestWaitUntilSpecificOutput().