Repository navigation
Use "containing/contained by" wording instead of arrow abbreviations - #1375
Merged
Merged
Conversation
- addresses issue #1368
mcking65
approved these changes
Jan 3, 2021
mcking65
left a comment
Contributor
There was a problem hiding this comment.
I like this so so much better! Thank you @carmacleod!
Contributor
Author
|
@pkra Added you as a reviewer because you gave a +1 in #1368 (comment). Very simple review - only 22 lines changed, and they're all the same pattern: remove the abbr for a left/right arrow symbol and replace it with the abbr's title text instead. :) |
pkra
approved these changes
Jan 7, 2021
Contributor
Author
|
@jnurthen Ready for final review. :) |
jnurthen
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1368 by removing the abbr problem completely and using words instead of arrows.
Preview | Diff