Skip to content

Change aria-keyshortcuts initial keyword from Indicates to Defines. - #1626

Merged
pkra merged 1 commit into
mainfrom
issue-1625
Jan 11, 2022
Merged

Change aria-keyshortcuts initial keyword from Indicates to Defines.#1626
pkra merged 1 commit into
mainfrom
issue-1625

Conversation

@cookiecrook

@cookiecrook cookiecrook commented Oct 14, 2021 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

Resolves #1625.

Preview | Diff

@cookiecrook

cookiecrook commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

@jnurthen ready for merge. Thanks @aleventhal and @scottaohara

@pkra

pkra commented Jan 10, 2022

Copy link
Copy Markdown
Member

ping @jnurthen.

This resolves #1625 which is technically in the 1.2 milestone. CI (travis) is marked hanging - not sure whether this can/should be merged.

@jnurthen

jnurthen commented Jan 10, 2022

Copy link
Copy Markdown
Member

ping @jnurthen.

This resolves #1625 which is technically in the 1.2 milestone. CI (travis) is marked hanging - not sure whether this can/should be merged.

Lets merge it (also stable) - We don't use travis any more so don't worry about anything hanging if it is as simple as this one.

@pkra pkra self-assigned this Jan 11, 2022
@pkra pkra added this to the ARIA 1.3 milestone Jan 11, 2022
@pkra
pkra merged commit 028bbbb into main Jan 11, 2022
@pkra
pkra deleted the issue-1625 branch January 11, 2022 08:00
@pkra pkra mentioned this pull request Jan 11, 2022
Closed
github-actions Bot added a commit that referenced this pull request Jan 11, 2022
@cookiecrook @github-actions
Change aria-keyshortcuts initial keyword from Indicates to Defines. R…
efca6cf 
…esolves Issue #1625. (#1626)

SHA: 028bbbb
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pkra pushed a commit that referenced this pull request Jul 14, 2022
@cookiecrook @pkra
Change aria-keyshortcuts initial keyword from Indicates to Defines. R…
d92f778 
…esolves Issue #1625. (#1626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkra pkra pkra approved these changes
@aleventhal aleventhal aleventhal approved these changes
@scottaohara scottaohara scottaohara approved these changes

Assignees

@pkra pkra

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

aria-keyshortcuts uses incorrect term "Indicates"; should use "Defines"

5 participants

@cookiecrook @pkra @jnurthen @aleventhal @scottaohara