Repository navigation
Conversation
Clarifies how text nodes fit into child role considerations. Resolves #2836
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Deployed on https://deploy-preview-2929--wai-aria.netlify.app |
|
This clarification seems easiest given the current set of 13 roles with child role restrictions. If we want to allow text nodes, more extensive changes are needed, cf. #2836 |
|
lgtm. This is preserving the status quo and making things more clear. Seems like a good soluiton |
spectranaut
left a comment
There was a problem hiding this comment.
If this is just a clarification, then I approve. But I am curious if validators call this out? Should we have ACT review, in case they want to add a rule? What do you think, @giacomo-petri ?
|
The ACT CG is working on aligning its rules with ARIA 1.3. Although the ARIA required owned elements rule still uses ARIA 1.2 terminology and will need to be updated, "Failed Example 1" covers a related scenario, albeit under a different condition. But in practice, accessibility tools already flag this error. I don't think this requires additional work in the context of this PR, but I think it's worth raising with the ACT CG so this scenario is explicitly considered during the ARIA 1.3 alignment. I'll add it to the ACT CG agenda for the next meeting so the group can assess whether the existing examples are sufficient or whether a more targeted set of examples would be useful. |
|
The ARIA Working Group just discussed The full IRC log of that discussion<jugglinmike> subtopic: clarification: text nodes and allowed accessibility child roles<jugglinmike> github: https://github.com//issues/2929 <giacomo-petri> q+ <jugglinmike> pkra: I don't know if this needs to be tagged for ACT review <jugglinmike> jamesn: We'll wait to hear back from them <jugglinmike> giacomo-petri: It's on the agenda for next week <jugglinmike> giacomo-petri: I've linked to a related issue in ARIA-HTML <jugglinmike> ack giacomo-petri |
| A list of roles which are allowed on an <a>accessibility child</a> of the element with this <a>role</a>. If the list is not empty, authors MUST only add <a>accessibility children</a> with | ||
| allowed roles. For example, an element with the role <rref>list</rref> allows <a>accessibility children</a> with the role <rref>listitem</rref>, but does not allow | ||
| <a>accessibility children</a> with the role <rref>option</rref>. If the list is empty, then there are no restrictions on accessibility child roles. | ||
| allowed roles; in particular, text nodes are not allowed in this case. If the list is empty, then there are no restrictions on accessibility children; in particular, text nodes are allowed in this case. |
There was a problem hiding this comment.
So
<ul>
<li>this is allowed</li>
this is not allowed
</ul>but…
<ul>
this is allowed by ARIA because there is no list item?
</ul>Any prose clarification should explain why. Presumably you may have been thinking about an example like this?
<ul>
loading…
</ul>But I'm not sure from diff alone. Nor am I certain why text nodes were called out separately from a paragrpagh node, for example.
There was a problem hiding this comment.
this is allowed by ARIA because there is no list item?
No, list (only) has listitem in its allowed child roles, so text nodes are not allowed.
| allowed roles; in particular, text nodes are not allowed in this case. If the list is empty, then there are no restrictions on accessibility children; in particular, text nodes are allowed in this case. | ||
| </p> | ||
| <p>For example, an element with the role <rref>list</rref> allows <a>accessibility children</a> with the role <rref>listitem</rref>, but does not allow | ||
| <a>accessibility children</a> with the role <rref>option</rref>. Reversely, an element with the role <rref>article</rref> has no restrictions and can contain any combination of elements and text nodes permitted by the host language. |
There was a problem hiding this comment.
"…except for option?" Again. I think this is confusing enough that it should explain why.
There was a problem hiding this comment.
I don't understand the "…except for option?" bit. Could you elaborate what part is confusing? (Is it perhaps mostly the unchanged language with the list/option example?)
🚀 Netlify Preview:
🔄 this PR updates the following specs:
Clarifies how text nodes fit into child role considerations.
Resolves #2836