Skip to content

Split out text level semantics - #202

Merged
scottaohara merged 5 commits into
gh-pagesfrom
split_out_text_level_semantics
Dec 6, 2019
Merged

scottaohara merged 5 commits into
gh-pagesfrom
split_out_text_level_semantics

Conversation

@scottaohara

@scottaohara scottaohara commented Dec 6, 2019 •

Copy link
Copy Markdown
Member

This PR takes the single row of text level semantics elements and provides them each with their own unique id and place in the table of elements.

dfn and br have updated information associated with them.

abbr was already listed separately, so this fixes the duplication of that element.

code will have a corresponding role when ARIA 1.2 is released, so this will be updated further in the future.


Preview | Diff

b, bdi, bdo, cite, code, data, i, kbd, mark, q, rp, rt, ruby, s, samp, u, var and wbr are now all listed individually, retaining the same allowances as when they were a single table row.

Note: `code` will have a specific role in ARIA 1.2

the following will be assigned to role generic in ARIA 1.2 (and an additional platform attribute may be created in 1.3): abbr, b, i, kbd, mark, q, s, samp, small, u, var
also adds `small`, missed from the previous commit.
`dfn` was listed as a text level semantic element, but was incorrect in it not having a corresponding role.  `<dfn>` maps to `role=term`.
add `br`, but unlike its previous allowances, a `br` element should only allow `presentation` and `none` roles, and not “ANY role”.
input type=submit should have been rendered within a `<code>` element.

@carmacleod carmacleod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good!

@scottaohara
scottaohara merged commit bb66bc6 into gh-pages Dec 6, 2019
@scottaohara
scottaohara deleted the split_out_text_level_semantics branch December 6, 2019 17:29
carmacleod added a commit to carmacleod/html that referenced this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants