Skip to content

Added 6 white-space-applies-to-text tests and references - #26877

Merged
fantasai merged 5 commits into
web-platform-tests:masterfrom
TalbotG:CSS3Text-GT-PR19
Sep 10, 2021
Merged

fantasai merged 5 commits into
web-platform-tests:masterfrom
TalbotG:CSS3Text-GT-PR19

Conversation

@TalbotG

@TalbotG TalbotG commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

css/css-text/white-space/white-space-applies-to-text-001.html
css/css-text/white-space/reference/white-space-applies-to-text-001-ref.html
css/css-text/white-space/white-space-applies-to-text-002.html
css/css-text/white-space/reference/white-space-applies-to-text-002-ref.html
css/css-text/white-space/white-space-applies-to-text-003.html
css/css-text/white-space/reference/white-space-applies-to-text-003-ref.html
css/css-text/white-space/white-space-applies-to-text-004.html
css/css-text/white-space/reference/white-space-applies-to-text-004-ref.html
css/css-text/white-space/white-space-applies-to-text-005.html
css/css-text/white-space/reference/white-space-applies-to-text-005-ref.html
css/css-text/white-space/white-space-applies-to-text-006.html
css/css-text/white-space/reference/white-space-applies-to-text-006-ref.html

This spun from Issue 5303 .
Credits should go to @Loirooriol for initially bringing this issue up and making an initial test.

At my website, these 12 files are:

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-001.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-001-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-002.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-002-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-003.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-003-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-004.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-004-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-005.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-005-ref.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-006.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-006-ref.html

@fantasai fantasai left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to reduce the font size a bit and combine these all into a single test file.
Also it should have a rel=help to https://www.w3.org/TR/css-display-3/#box-generation

Otherwise looks good.

@TalbotG

TalbotG commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

combine these all into a single test file.

This may not be possible if we want tests to comply with the
600px wide by 600px tall window viewport requirement

@TalbotG
TalbotG requested a review from fantasai February 26, 2021 22:24
@TalbotG

TalbotG commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

I finally merged all 6 tests into 1 test. I used a font-size of 14px and a line-height of 1 and then made sure that the meta-6-subtests file and its reference were both complying with the 600px wide by 600px tall window viewport requirement.

Over at my website:

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/white-space-applies-to-text-009.html

http://www.gtalbot.org/BrowserBugsSection/CSS3Text/reference/white-space-applies-to-text-009-ref.html

@fantasai
fantasai merged commit 7e8db43 into web-platform-tests:master Sep 10, 2021
@TalbotG
TalbotG deleted the CSS3Text-GT-PR19 branch October 29, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants