Repository navigation
script: Use constellation event's mouse button state instead of tracking count - #60647
Closed
servo-wpt-sync wants to merge 1 commit into
Closed
servo-wpt-sync wants to merge 1 commit into
servo-wpt-sync wants to merge 1 commit into
Conversation
wpt-pr-bot
approved these changes
Jun 15, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_45628
branch
from
June 16, 2026 13:07
ca596f7 to
4f03093
Compare
Signed-off-by: Oskar Steiger <steigeo@rose-hulman.edu>
servo-wpt-sync
force-pushed
the
servo_export_45628
branch
from
June 30, 2026 18:24
4f03093 to
1848e69
Compare
Collaborator
Author
|
👋 Downstream pull request (servo/servo#45628) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of keeping track of the number of mouse buttons currently pressed from within the document event handler, we use the input event from the constellation as the source of truth for currently pressed mouse buttons. This fixes an issue where the internal count would permanently increase, preventing the firing of
pointerup/pointerdownevents.This also fixes an issue where the
buttonsfield of pointer capture boundary transition events was improperly set to a button count instead of an integer bitmap.Testing: A test was added for the
buttonsfield behavior. For the non-firingpointerup/pointerdownevents, is this something testable with WPT? It's caused by the embedder not sending a corresponding mouse up event with a mouse down one, so I'm not sure if WPT can enable us to test this. Please let me know!Fixes: Partially fixes servo/servo#45491, prevents
pointerup/pointerdownevents from breaking entirely.Reviewed in servo/servo#45628