Repository navigation
script: Use constellation event's mouse button state instead of tracking count - #45628
Conversation
|
Marking as draft for now so I can find which WPT tests have changed state. |
|
🔨 Triggering try run (#27528675703) for Linux (WPT) |
|
Test results for linux-wpt from try job (#27528675703): Flaky unexpected result (56)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (7)
|
|
|
2fe4248 to
cb4ae21
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#60647) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#60647) title and body. |
|
The test seems to have timeout issues in other browsers. I'll probably reduce the number of chords tested to increase the speed of the tests to see if that addresses these issues. |
cb4ae21 to
c3a273f
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#60647). |
|
Not sure why we're still running into timeout issues in other browsers -- upon manual testing, the same behavior seems to work fine in both Firefox and Chromium. Maybe the other browsers are somehow reading the mouse inputs (forward/back buttons) as navigation instructions? But performing the same actions manually doesn't cause navigation in these browsers. I'll look into setting up a WPT environment for other browsers on my machine to find the cause of this issue. |
c3a273f to
da61ce9
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#60647). |
da61ce9 to
64490c7
Compare
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#60647). |
Signed-off-by: Oskar Steiger <steigeo@rose-hulman.edu>
64490c7 to
7f8bd5c
Compare
|
Also fixes #47300 |
…ing count (servo#45628) Instead of keeping track of the number of mouse buttons currently pressed from within the document event handler, we use the input event from the constellation as the source of truth for currently pressed mouse buttons. This fixes an issue where the internal count would permanently increase, preventing the firing of `pointerup`/`pointerdown` events. This also fixes an issue where the `buttons` field of pointer capture boundary transition events was improperly set to a button count instead of an integer bitmap. Testing: The issue is caused by the embedder not sending a corresponding mouse up event with a mouse down one, so I'm not sure if WPT can enable us to test this. Fixes: Partially fixes servo#45491, prevents `pointerup`/`pointerdown` events from breaking entirely. Fixes servo#47300. Signed-off-by: Oskar Steiger <steigeo@rose-hulman.edu>
Instead of keeping track of the number of mouse buttons currently pressed from within the document event handler, we use the input event from the constellation as the source of truth for currently pressed mouse buttons. This fixes an issue where the internal count would permanently increase, preventing the firing of
pointerup/pointerdownevents.This also fixes an issue where the
buttonsfield of pointer capture boundary transition events was improperly set to a button count instead of an integer bitmap.Testing: The issue is caused by the embedder not sending a corresponding mouse up event with a mouse down one, so I'm not sure if WPT can enable us to test this.
Fixes: Partially fixes #45491, prevents
pointerup/pointerdownevents from breaking entirely.Fixes #47300.