Repository navigation
Added a test for LCP text fragment union. - #61873
Merged
Merged
Conversation
shubhamg13
force-pushed
the
lcp_text_union
branch
from
August 12, 2026 01:53
fec96e7 to
d338eb2
Compare
Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
shubhamg13
force-pushed
the
lcp_text_union
branch
from
August 12, 2026 01:56
d338eb2 to
dd24355
Compare
noamr
approved these changes
Aug 13, 2026
Contributor
Author
|
Please help me in merging this as well. |
markafoltz
pushed a commit
to markafoltz/web-platform-tests
that referenced
this pull request
Aug 17, 2026
Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
mrobinson
pushed a commit
to mrobinson/servo
that referenced
this pull request
Aug 18, 2026
Since the spec says, for text nodes we need to do union of border box per element. - Adding `containing_element_tag` for making this union. - Adding `TextRecord` to store `TextNodes` related to an `Element`. > Note: Please view using `Hide whitespace` option. Testing: More WPT Passed - Added a specific test to verify union logic of rect - size calculation is correct in WPT - `tests/wpt/tests/largest-contentful-paint/text-fragment-union.html`- web-platform-tests/wpt#61873 - (_TODO: set loadTime to zero for text, other failing tests will also pass #47315_) Fixes: Part of servo#42000 --------- Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Since the spec says, for text nodes we need to do union of border box per element. - Adding `containing_element_tag` for making this union. - Adding `TextRecord` to store `TextNodes` related to an `Element`. > Note: Please view using `Hide whitespace` option. Testing: More WPT Passed - Added a specific test to verify union logic of rect - size calculation is correct in WPT - `tests/wpt/tests/largest-contentful-paint/text-fragment-union.html`- web-platform-tests/wpt#61873 - (_TODO: set loadTime to zero for text, other failing tests will also pass #47315_) Fixes: Part of servo#42000 --------- Signed-off-by: Shubham Gupta <shubhamg13.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new test for LCP text fragment union.
Create a text element narrow enough to force line wrapping across
multiple fragments. Without correct union, only a single line's
bounding box would be reported instead of all lines combined.