Cleanup Window's close(d) members by annevk · Pull Request #4402 · whatwg/html

annevk · 2019-03-01T13:51:32Z

Tests: web-platform-tests/wpt#15561.

Helps with #4363.

/browsers.html ( diff )
/window-object.html ( diff )

Tests: web-platform-tests/wpt#15561.

domenic

Editorially LGTM; were there questions about the correct behavior for these ones?

annevk · 2019-03-01T16:49:02Z

Yeah, see #3734 and pointers from there. I didn't do anything to try address those.

domenic · 2019-03-01T17:40:45Z

Wrong issue link?

But I meant, it seems like the ones in this patch are uncontroversial. Right?

annevk · 2019-03-01T17:55:33Z

No, that issue is relevant for close(). I don't think any of changes are controversial, indeed.

domenic

Task source/event loop is the main remaining thing. It seems not too hard to do so I'd say might as well do it now?

Also will want a new commit message.

domenic

LGTM but examples would be a nice bonus.

For whatwg/html#4402.

annevk · 2019-03-07T15:49:17Z

Filed https://bugs.webkit.org/show_bug.cgi?id=195409 on Safari and #4417 for examples.

For whatwg/html#4402.

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649

For whatwg/html#4402.

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561 UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649 UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561 UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649 UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561 UltraBlame original commit: 88d4845c21396701d526fd9b1303fe715b3e065f

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649 UltraBlame original commit: 8ab89f51fe694e4f03177084635f89b7512c9bbb

Automatic update from web-platform-tests HTML: window.closed For whatwg/html#4402. -- wpt-commits: 391ee6b42d91d930f73825912b32928ea32f004c wpt-pr: 15561

…lose(), a=testonly Automatic update from web-platform-tests HTML: test queueing behavior of window.close() For whatwg/html#4402. -- wpt-commits: bdb6041d03facf7c79c9df62659c6bd0fb2adfc3 wpt-pr: 15649

Cleanup Window's close(d) members

d51458c

Tests: web-platform-tests/wpt#15561.

domenic approved these changes Mar 1, 2019

View reviewed changes

domenic added the topic: frames/navigables/browsing contexts label Mar 1, 2019

annevk added the do not merge yet Pull request must not be merged per rationale in comment label Mar 1, 2019

annevk mentioned this pull request Mar 1, 2019

Behavior of window.close() #4405

Closed

add is closing boolean

75c0a2d

annevk commented Mar 4, 2019

View reviewed changes

Comment thread source Outdated

annevk mentioned this pull request Mar 4, 2019

Disowning owner should perhaps affect link targeting #313

Closed

annevk added 2 commits March 4, 2019 14:15

grammar

134e6b6

markup error

efcaaf6

annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Mar 4, 2019

annevk added 2 commits March 4, 2019 15:01

close p element

614375f

while here, also modernize stop()

fa50b26

domenic reviewed Mar 6, 2019

View reviewed changes

Comment thread source

Comment thread source Outdated

Comment thread source Outdated

feedback

2380d85

domenic approved these changes Mar 7, 2019

View reviewed changes

annevk mentioned this pull request Mar 7, 2019

Create examples for "is closing" and "disowned" #4417

Closed

annevk added a commit to web-platform-tests/wpt that referenced this pull request Mar 7, 2019

HTML: window.closed

391ee6b

For whatwg/html#4402.

annevk merged commit 37b1ce5 into master Mar 7, 2019

annevk deleted the annevk/window-close(d) branch March 7, 2019 15:47

annevk mentioned this pull request Mar 7, 2019

HTML: test queueing behavior of window.close() web-platform-tests/wpt#15649

Merged

annevk added a commit to web-platform-tests/wpt that referenced this pull request Mar 8, 2019

HTML: test queueing behavior of window.close()

bdb6041

For whatwg/html#4402.

marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019

HTML: window.closed

2cf2eec

For whatwg/html#4402.

marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019

HTML: test queueing behavior of window.close()

a656459

For whatwg/html#4402.

hober mentioned this pull request Dec 10, 2019

HTML horizontal review: Browsing contexts w3ctag/design-reviews#452

Closed

6 tasks done

Navigation Menu

Repository navigation

Cleanup Window's close(d) members - #4402

Cleanup Window's close(d) members#4402
annevk merged 7 commits into
masterfrom
annevk/window-close(d)

annevk commented Mar 1, 2019 •

edited by pr-preview Bot

Loading

Uh oh!

domenic left a comment

Uh oh!

annevk commented Mar 1, 2019

Uh oh!

domenic commented Mar 1, 2019

Uh oh!

annevk commented Mar 1, 2019

Uh oh!

Uh oh!

domenic left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

domenic left a comment

Uh oh!

annevk commented Mar 7, 2019 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

annevk commented Mar 1, 2019 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domenic left a comment

Choose a reason for hiding this comment

Uh oh!

annevk commented Mar 1, 2019

Uh oh!

domenic commented Mar 1, 2019

Uh oh!

annevk commented Mar 1, 2019

Uh oh!

Uh oh!

domenic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

domenic left a comment

Choose a reason for hiding this comment

Uh oh!

annevk commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

annevk commented Mar 1, 2019 •

edited by pr-preview Bot

Loading

domenic left a comment •

edited

Loading

annevk commented Mar 7, 2019 •

edited

Loading