Repository navigation
Ignore document.open/write after the active parser has been aborted - #4907
Merged
Merged
Conversation
domenic
reviewed
Sep 13, 2019
bzbarsky
approved these changes
Oct 13, 2019
bzbarsky
left a comment
Contributor
There was a problem hiding this comment.
This looks great. Thank you for putting it together, and my apologies for the horrible review lag...
Contributor
|
@rniwa Do you know who on the WebKit side should take a look at this? |
Member
|
I filed a WebKit bug at https://bugs.webkit.org/show_bug.cgi?id=203028 (also in the OP with the Gecko and Blink bugs) |
|
Are there WPT tests for this? |
Member
yury-s
pushed a commit
to yury-s/webkit-http
that referenced
this pull request
Oct 23, 2019
https://bugs.webkit.org/show_bug.cgi?id=203028 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT test that is now passing. * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window-expected.txt: Source/WebCore: Ignore document.open/write after the active parser has been aborted, as per: - whatwg/html#4907 Test: imported/blink/fast/loader/document-write-after-location-change.html * dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::write): * dom/Document.h: LayoutTests: Import test from blink. * imported/blink/fast/loader/document-write-after-location-change-expected.txt: Added. * imported/blink/fast/loader/document-write-after-location-change.html: Added. * imported/blink/fast/loader/resources/pass-and-notify-done.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This was referenced Apr 13, 2020
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4723.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/dynamic-markup-insertion.html ( diff )