fix: avoid menu bar crash when GTK cannot initialize by claude[bot] · Pull Request #54859 · electron/electron

claude · 2026-10-12T18:14:09Z

Requested by Charles Kerr · Slack thread

Description of Change

Manual backport of #54777. See that PR for details.

The only conflict was in the #include block of shell/browser/ui/gtk_util.cc, where 44-x-y still includes SkUnPreMultiply.h; it was kept alongside the two new includes.

Checklist

I have built and tested this change
I have filled out the PR description
I have reviewed and verified the changes
npm test passes
tests are changed or added
relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

🤖 Generated with Claude Code

https://claude.ai/code/session_015GReMcdLqJ1Grhw5C8TvVx

Release Notes

Notes: Fixed a Linux crash creating a window with a menu bar when GTK failed to load.

* fix: avoid menu bar crash when GTK cannot initialize Guard GTK menu color lookups on toolkit theme availability and fall back to Views menu colors when GTK initialization fails. Cover framed window creation and theme refresh with an incompatible Wayland GSettings schema. Fixes #54594 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: check GTK availability with one helper Add gtk_util::IsGtkAvailable() and use it for the menu bar's GTK color lookup. Also use it in the icon lookup behind app.getApplicationInfoForProtocol(), which called into GTK the same way and crashed when GTK was not loaded. Run api-menu.spec.ts on the Wayland CI leg so the new spec runs in CI, and describe the fallback menu colors accurately in the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: give the no-GTK menu spec's schema the toolkit-accessibility key In CI there is no accessibility D-Bus service and no accessibility env var, so Chromium's accessibility check falls back to reading toolkit-accessibility from org.gnome.desktop.interface. The spec's minimal schema lacked that key, so GLib aborted the app with SIGTRAP. Real schemas that predate font-antialiasing still have toolkit-accessibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9cb9173) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GReMcdLqJ1Grhw5C8TvVx

release-clerk · 2026-10-13T06:41:37Z

Release Notes Persisted

Fixed a Linux crash creating a window with a menu bar when GTK failed to load.

trop · 2026-10-13T06:41:51Z

I was unable to backport this PR to "43-x-y" cleanly;
you will need to perform this backport manually.

##### [v44.9.0](https://github.com/electron/electron/releases/tag/v44.9.0) ### Release Notes for v44.9.0 #### Features - Added app shims on macOS to show windows under another app's Dock icon. [#55073](electron/electron#55073) (Also in [45](https://github.com/electron/electron/pull/55072)) #### Fixes - Fixed link-opened windows not using the opener's session and `webPreferences`. [#55048](electron/electron#55048) (Also in [42](electron/electron#55050), [43](electron/electron#55049), [45](https://github.com/electron/electron/pull/55051)) - Fixed `setCertificateVerifyProc` occasionally not being applied to a request issued concurrently with the first request to a host. [#55046](electron/electron#55046) (Also in [42](electron/electron#55054), [43](electron/electron#55047), [45](https://github.com/electron/electron/pull/55045)) ##### [v44.8.0](https://github.com/electron/electron/releases/tag/v44.8.0) ### Release Notes for v44.8.0 #### Features - Added support for `Notification` action buttons on Linux. [#54890](electron/electron#54890) (Also in [45](https://github.com/electron/electron/pull/54889)) #### Fixes - Fixed mouse cursor missing over native dialogs in certain scenarios on Windows. [#54987](electron/electron#54987) - Fixed `net.fetch` and `session.fetch` failing permanently with `net::ERR_FAILED` after the Network Service process restarts. [#54909](electron/electron#54909) (Also in [42](electron/electron#54925), [43](electron/electron#54908), [45](https://github.com/electron/electron/pull/54910)) - Fixed `utilityProcess` dropping messages posted with `process.parentPort.postMessage()` right before the process exits. [#54960](electron/electron#54960) (Also in [42](electron/electron#55000), [43](electron/electron#54962), [45](https://github.com/electron/electron/pull/54956)) - Fixed `win.isFullScreen()` being stale in fullscreen events on Windows. [#55009](electron/electron#55009) (Also in [45](https://github.com/electron/electron/pull/55008)) #### Other Changes - Backported fixes from upstream Chromium and V8. [#55034](electron/electron#55034) - Updated Chromium to 152.0.7977.167. [#54928](electron/electron#54928) - Updated Node.js to v24.22.0. [#55004](electron/electron#55004) ##### [v44.7.2](https://github.com/electron/electron/releases/tag/v44.7.2) ### Release Notes for v44.7.2 #### Fixes - Fixed an issue where clicks posted to a background app were dropped on macOS. [#54819](electron/electron#54819) (Also in [45](https://github.com/electron/electron/pull/54818)) - Fixed interrupted macOS updates leaving a broken app behind. [#54844](electron/electron#54844) (Also in [45](https://github.com/electron/electron/pull/54843)) #### Other Changes - Backported fixes from upstream ANGLE, Chromium, PDFium and V8. [#54898](electron/electron#54898) #### Documentation - Documentation changes: [#54880](electron/electron#54880) ##### [v44.7.1](https://github.com/electron/electron/releases/tag/v44.7.1) ### Release Notes for v44.7.1 #### Fixes - Fixed a crash when starting without an available display server on Linux. [#54794](electron/electron#54794) (Also in [45](https://github.com/electron/electron/pull/54781)) - Fixed a Linux crash creating a window with a menu bar when GTK failed to load. [#54859](electron/electron#54859) (Also in [45](https://github.com/electron/electron/pull/54846)) - Fixed a `WebContentsView` that was removed with `removeChildView()` and re-added with `addChildView()` staying hidden behind its sibling views on Linux. [#54798](electron/electron#54798) - Fixed asar archives in non-ASCII folders failing to load on Linux. [#54849](electron/electron#54849) (Also in [45](https://github.com/electron/electron/pull/54848)) - Fixed renderer crashes during garbage collection inside ShadowRealms. [#54865](electron/electron#54865) (Also in [45](https://github.com/electron/electron/pull/54864)) #### Other Changes - Refactored mouse forwarding on Windows to fix `setIgnoreMouseEvents(true, { forward: true })` related issues. [#54802](electron/electron#54802) (Also in [45](https://github.com/electron/electron/pull/54803)) - Updated Chromium to 152.0.7977.149. [#54085](electron/electron#54085) ##### [v44.7.0](https://github.com/electron/electron/releases/tag/v44.7.0) ### Release Notes for v44.7.0 #### Features - The macOS `autoUpdater` now streams update downloads to disk, resumes an interrupted download on the next check instead of starting over, and applies a binary delta when the update feed offers one for the running version. [#54204](electron/electron#54204) #### Fixes - Fixed an uncatchable TypeError in `net.fetch` when receiving response headers with non-ASCII characters, and preserved multiple Set-Cookie headers. [#54672](electron/electron#54672) #### Other Changes - Backported fixes from upstream ANGLE, Chromium, Dawn, fontconfig, Skia, V8 and WebRTC. [#54666](electron/electron#54666) - Backported fixes from upstream ANGLE, Chromium, Skia, V8 and WebRTC. [#54657](electron/electron#54657) ##### [v44.6.0](https://github.com/electron/electron/releases/tag/v44.6.0) ### Release Notes for v44.6.0 #### Features - Added the experimental `protocol.registerSource()` to serve a custom scheme from directories on disk without a JavaScript handler. [#54522](electron/electron#54522) (Also in [45](https://github.com/electron/electron/pull/54521)) #### Fixes - Fixed a crash on launch on macOS when the system refused to register the app for sleep/wake notifications. [#54596](electron/electron#54596) - Fixed a crash on `navigator.usb.requestDevice()` in in-memory sessions. [#54616](electron/electron#54616) (Also in [45](https://github.com/electron/electron/pull/54615)) - Fixed `webview.findInPage()` hanging when the host page also has an iframe. [#54586](electron/electron#54586) (Also in [43](electron/electron#54584), [45](https://github.com/electron/electron/pull/54585)) - Updated time zone data to tzdata 2026d, including British Columbia's move to permanent UTC-7. [#54623](electron/electron#54623) #### Documentation - Documentation changes: [#54589](electron/electron#54589)

trop Bot mentioned this pull request Oct 12, 2026

fix: avoid menu bar crash when GTK cannot initialize #54777

Merged

7 tasks done

trop Bot requested a review from ckerr October 12, 2026 18:14

trop Bot added 44-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 12, 2026

claude Bot added the target/43-x-y PR should also be added to the "43-x-y" branch. label Oct 12, 2026

claude Bot assigned ckerr Oct 12, 2026

ckerr approved these changes Oct 12, 2026

View reviewed changes

dsanders11 approved these changes Oct 13, 2026

View reviewed changes

dsanders11 merged commit 3d03501 into 44-x-y Oct 13, 2026
94 checks passed

dsanders11 deleted the manual-bp/claude/pr/54777/branch/44-x-y branch October 13, 2026 06:41

electron-release-board Bot added this to 44-x-y Oct 13, 2026

trop Bot removed the target/43-x-y PR should also be added to the "43-x-y" branch. label Oct 13, 2026

claude Bot mentioned this pull request Oct 13, 2026

fix: avoid menu bar crash when GTK cannot initialize #54884

Merged

5 of 7 tasks

Navigation Menu

Repository navigation

fix: avoid menu bar crash when GTK cannot initialize - #54859

fix: avoid menu bar crash when GTK cannot initialize#54859
dsanders11 merged 1 commit into
44-x-yfrom
manual-bp/claude/pr/54777/branch/44-x-y

claude Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

release-clerk Bot commented Oct 13, 2026

Uh oh!

trop Bot commented Oct 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

claude Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

Uh oh!

release-clerk Bot commented Oct 13, 2026

Uh oh!

trop Bot commented Oct 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

claude Bot commented Oct 12, 2026 •

edited

Loading