perf(packages/codegen): remove redundant setting of last in printImportAttributes and printIf - #25882
Merged
Conversation
This was referenced Aug 18, 2026
Member
Author
This was referenced Aug 18, 2026
Merged
overlookmotel
marked this pull request as ready for review
August 18, 2026 16:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes a small performance-focused cleanup in the JavaScript code generator by avoiding redundant updates to state.last in two printing paths where the value is immediately superseded before any reader can observe it.
Changes:
- Use
writeNoLastinprintIfwhen emitting") "immediately followed by a write that overwritesstate.last. - Use
writeNoLastinprintImportAttributeswhen emitting the leading space before establishing the mapping anchor and writing"with { ".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/codegen/src-js/print/statement.ts | Avoids redundant state.last update in the ambiguous-else wrapping branch of printIf. |
| packages/codegen/src-js/print/module.ts | Avoids redundant state.last update when printing the leading space for with { … } import attributes. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
camc314
approved these changes
Aug 18, 2026
Contributor
Merge activity
|
graphite-app
Bot
force-pushed
the
om/08-18-perf_packages_codegen_combine_2_writes_in_printjsxelement_
branch
from
August 18, 2026 16:54
9a09c76 to
c6e44c6
Compare
graphite-app
Bot
force-pushed
the
om/08-18-perf_packages_codegen_remove_redundant_setting_of_last_in_printimportattributes_and_printif_
branch
from
August 18, 2026 16:55
edd20ed to
a734af5
Compare
Base automatically changed from
om/08-18-perf_packages_codegen_combine_2_writes_in_printjsxelement_
to
main
August 18, 2026 16:59
graphite-app
Bot
deleted the
om/08-18-perf_packages_codegen_remove_redundant_setting_of_last_in_printimportattributes_and_printif_
branch
August 18, 2026 17:01
graphite-app Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
### 🚀 Features - 83cb516 minifier: Improve negation of expressions in boolean context (#25755) (Armano) ### 🐛 Bug Fixes - 134fb22 isolated-declarations: Preserve unresolved parameter types (#25909) (Dunqing) - 526c2b3 codegen: Remove deprecated test APIs (#25889) (camc314) - 344a9b2 codegen: Align enum template sourcemaps (#25872) (camc314) ### ⚡ Performance - 5ef0c93 minifier: Unwrap all unary exprs without creating dummy expressions (#25891) (Armano) - 8783524 packages/codegen: Remove loop from `growMappingBuffer` (#25886) (overlookmotel) - b6b14c0 packages/codegen: Remove redundant branch (#25885) (overlookmotel) - be6adf0 packages/sourcemap: Make `location` passed to `recordSourceMapping` always a number (#25884) (overlookmotel) - f720f15 packages/codegen: Take named-mapping only code off hot path in `recordSourceMapping` (#25883) (overlookmotel) - a734af5 packages/codegen: Remove redundant setting of `last` in `printImportAttributes` and `printIf` (#25882) (overlookmotel) - c6e44c6 packages/codegen: Combine 2 writes in `printJSXElement` (#25881) (overlookmotel) - 8801662 packages/codegen: Remove redundant mapping from `printParams` (#25880) (overlookmotel) ### 📚 Documentation - 5ad330e packages/codegen: Reformat comments (#25876) (overlookmotel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #25585. Small optimization.
No point setting
lasthere, since in both cases its immediately overwritten before anything else can read it.