fix(formatter_css): preserve comments around SCSS/Less variable values by leaysgur · Pull Request #26276 · oxc-project/oxc

leaysgur · 2026-09-03T07:49:59Z

// input
@a: /* c */ 1;

// before
@a: 1;

// after
@a: /* c */ 1;

Comment should be preserved.

// input
$x: // c
  1;

// before
$x:
  // c1;

// after
$x: // c
  1;

Content should be preserved.

leaysgur · 2026-09-03T07:50:23Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

oxc-guard · 2026-09-03T07:52:33Z

Oxfmt Ecosystem CI

suite	oxfmt@latest	main	refs/pull/26276/head branch
fuma-nama/fumadocs	✅	✅	✅
formatjs/formatjs	❌	✅	✅
cnpm/cnpmcore	❌	✅	✅
vuejs/pinia	❌	✅	✅
monkeytypegame/monkeytype	❌	🟨	✅
eggjs/egg	❌	✅	✅
tale/headplane	❌	🟨	✅
cloudflare/workers-sdk	❌	✅	✅
getsentry/sentry-javascript	✅	✅	✅
Comfy-Org/ComfyUI_frontend	❌	✅	✅
AmanVarshney01/create-better-t-stack	✅	✅	✅
actualbudget/actual	❌	✅	✅
aidenybai/react-grab	❌	✅	✅
cloudflare/agents	❌	✅	✅
mastodon/mastodon	⚠️	✅	✅
vercel/turborepo	❌	✅	✅
mantinedev/mantine	✅	✅	✅
fastify/fastify-vite	❌	✅	✅
rolldown/rolldown	✅	✅	✅
huggingface/huggingface.js	❌	✅	✅
lichess-org/lila	❌	✅	✅
dyad-sh/dyad	❌	✅	✅
vuejs/core	✅	✅	✅
openclaw/openclaw	❌	✅	✅
cloudflare/kumo	✅	🟨	✅
npmx-dev/npmx.dev	✅	✅	✅

💥 = panic, ⚠️ = error e.g. parse error (main/branch columns: only new errors), ❌ = diff or exit code mismatch, 🟨 = differs from oxfmt@latest (merged-but-unreleased changes)

codspeed · 2026-09-03T07:53:55Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 19 skipped benchmarks¹

_{Comparing 09-03-fix_formatter_css_preserve_comments_around_scss_less_variable_values (a602fe7) with main (07851b9)²}

19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on 09-03-fix_formatter_css_keep_leading_comments_before (00b7eba) during the generation of this report, so main (07851b9) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

leaysgur · 2026-09-03T08:16:51Z

Merge activity

Sep 3, 8:16 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 3, 8:17 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Sep 3, 8:32 AM UTC: Merged by the Graphite merge queue.

@A

#26276) ```less // input @A: /* c */ 1; // before @A: 1; // after @A: /* c */ 1; ``` Comment should be preserved. ```scss // input $x: // c 1; // before $x: // c1; // after $x: // c 1; ``` Content should be preserved.

# Oxlint ### 🚀 Features - 6a0e19c linter/eslint/no-unmodified-loop-condition: Support `checkConditionalExpressions` option (#26249) (camc314) ### 🐛 Bug Fixes - 562dd14 jsx-a11y/anchor-has-content: Allow anchors passed as custom component props (#26360) (Mikhail Baev) - 253cdb2 linter/eslint/id-length: Exempt TS interface/type-literal members with never (#26310) (Pearce Ropion) - 8c7ea76 ast_visit: Account for trimmed source offsets (#26223) (Cameron) - 5f9cffc linter/typescript/no-explicit-any: Fix rest parameter to `unknown[]` (#26279) (camc314) - 4de9fa3 linter/react/jsx-no-literals: Check nested JSX expression literals (#26253) (camc314) - 07851b9 parser: Fix debug assert failure when lexer error with tokens enabled (#26229) (overlookmotel) - 9cee146 oxlint/lsp: Don't try to parse fix message, always fallback (#26204) (Sysix) - a662c40 linter/eslint/no-useless-assignment: Handle destructuring assignments (#25925) (camc314) - 304bd9a linter/eslint/no-array-constructor: Handle ASI hazards in fixer (#26166) (Hamody We) - b41bb35 linter: Qualify rules in rules output (#26250) (camc314) - 895c685 linter/typescript/no-extraneous-class: Avoid deleting class expressions (#26231) (camc314) - 4ba33c8 linter/eslint/no-unused-vars: Handle stored arrow references (#26225) (camc314) ### 🛡️ Security - 9a612d5 deps: Update npm packages (#26178) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 2c9a947 parser: [**BREAKING**] Reduce `MAX_LEN` to 256 bytes below `u32::MAX` (#26352) (overlookmotel) ### 🚀 Features - 68e12ab formatter_css: Follow the oxc-css-parser's acceptance line (#26337) (leaysgur) ### 🐛 Bug Fixes - f7acdc0 formatter: Treat a JSDoc cast target as opaque in chain layouts (#26375) (leaysgur) - 104061b formatter: Keep JSDoc cast parens with a comment inside them (#26374) (leaysgur) - 3d00a76 formatter_css: Keep comment inside important and simple-vars colon (#26370) (leaysgur) - 172ddb6 formatter_css: Keep a same-line line comment on its line (#26321) (leaysgur) - cafaf32 formatter_css: Never drop comments inside an at-rule prelude (#26320) (leaysgur) - 534a0fe formatter_css: Keep a line comment on its comma's line (#26319) (leaysgur) - 99cfd75 formatter_css: Hide raw comment printing API, use strcut instead (#26316) (leaysgur) - 2028896 formatter_css: Preserve comments around SCSS/Less variable values (#26276) (leaysgur) - 6752abc formatter_css: Keep leading comments before (#26272) (leaysgur) - 3b054de formatter_graphql: Align comment printing after open `{` (#26271) (leaysgur) - b3c287a formatter_css: Fix SCSS bracket list printing (#26270) (leaysgur) - bac770a formatter_css: Preserve comment in SCSS paren comma list (#26269) (leaysgur) - c7b57ef formatter_css: Print SCSS map consisntent with and without comment (#26268) (leaysgur) - 063e2b6 formatter_css: Preserve trailing comma in single-item scss lists (#26245) (leaysgur) - 5f9580d oxfmt: Bump prettier-plugin-tailwindcss (#26273) (leaysgur) ### ⚡ Performance - 1cad286 oxfmt: Match editorconfig once per file (#26239) (Yuji Sugiura) - 260c5eb oxfmt: Match `overrides` once per file (#26238) (leaysgur) - 61565bc oxfmt: Share resolved `FormatConfig` via `Arc` instead of cloning per file (#26237) (leaysgur) ### 📚 Documentation - 32084d4 formatter_core: Clarify printer hard_line compression (#26312) (leaysgur) - 4fabdcc formatter,formatter_css,formatter_graphql,formatter_yaml: Update DIVERGENCES.md (#26267) (leaysgur) - 26a1fa4 formatter_core: Refine FORMATTER_POLICY (#26266) (leaysgur) ### 🛡️ Security - 9a612d5 deps: Update npm packages (#26178) (renovate[bot])

github-actions Bot added the A-formatter Area - Formatter label Sep 3, 2026

This was referenced Sep 3, 2026

fix(formatter_css): fix SCSS bracket list printing #26270

Merged

fix(formatter_graphql): align comment printing after open { #26271

Merged

leaysgur mentioned this pull request Sep 3, 2026

fix(formatter_css): keep leading comments before #26272

Merged

leaysgur added the run-oxfmt-ecosystem-ci label Sep 3, 2026

oxc-guard Bot removed the run-oxfmt-ecosystem-ci label Sep 3, 2026

leaysgur force-pushed the 09-03-fix_formatter_css_preserve_comments_around_scss_less_variable_values branch from 2c33ed9 to a602fe7 Compare September 3, 2026 08:06

leaysgur force-pushed the 09-03-fix_formatter_css_keep_leading_comments_before branch from 6d256df to 00b7eba Compare September 3, 2026 08:06

leaysgur added the run-oxfmt-ecosystem-ci label Sep 3, 2026

oxc-guard Bot removed the run-oxfmt-ecosystem-ci label Sep 3, 2026

leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 3, 2026

graphite-app Bot force-pushed the 09-03-fix_formatter_css_keep_leading_comments_before branch from 00b7eba to 6752abc Compare September 3, 2026 08:21

graphite-app Bot force-pushed the 09-03-fix_formatter_css_preserve_comments_around_scss_less_variable_values branch from a602fe7 to 2028896 Compare September 3, 2026 08:22

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Sep 3, 2026

Base automatically changed from 09-03-fix_formatter_css_keep_leading_comments_before to main September 3, 2026 08:31

graphite-app Bot merged commit 2028896 into main Sep 3, 2026
33 checks passed

graphite-app Bot deleted the 09-03-fix_formatter_css_preserve_comments_around_scss_less_variable_values branch September 3, 2026 08:32

oxc-guard Bot mentioned this pull request Sep 7, 2026

release(apps): oxlint v1.82.0 && oxfmt v0.67.0 #26384

Merged

Navigation Menu

Uh oh!

fix(formatter_css): preserve comments around SCSS/Less variable values - #26276

fix(formatter_css): preserve comments around SCSS/Less variable values#26276
graphite-app[bot] merged 1 commit into
mainfrom
09-03-fix_formatter_css_preserve_comments_around_scss_less_variable_values

leaysgur commented Sep 3, 2026

Uh oh!

leaysgur commented Sep 3, 2026 •

edited

Loading

Uh oh!

oxc-guard Bot commented Sep 3, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 3, 2026 •

edited

Loading

Uh oh!

leaysgur commented Sep 3, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

leaysgur commented Sep 3, 2026

Uh oh!

leaysgur commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

oxc-guard Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Oxfmt Ecosystem CI

Uh oh!

codspeed Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

leaysgur commented Sep 3, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

leaysgur commented Sep 3, 2026 •

edited

Loading

oxc-guard Bot commented Sep 3, 2026 •

edited

Loading

codspeed Bot commented Sep 3, 2026 •

edited

Loading

leaysgur commented Sep 3, 2026 •

edited by graphite-app Bot

Loading