fix(linter/eslint/id-length): exempt TS interface/type-literal members with never - #26310
Merged
Merged
Conversation
…ype-literal members TSPropertySignature and TSMethodSignature keys fall through to the default match arm in id-length's handle_identifier_name, so they were checked unconditionally regardless of the properties option, unlike ObjectProperty. Fixes oxc-project#26309
Pearce-Ropion
commented
Sep 4, 2026
camc314
reviewed
Sep 4, 2026
Signed-off-by: Cameron <cameron.clark@hey.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
# Oxlint ### 🚀 Features - 6a0e19c linter/eslint/no-unmodified-loop-condition: Support `checkConditionalExpressions` option (#26249) (camc314) ### 🐛 Bug Fixes - 562dd14 jsx-a11y/anchor-has-content: Allow anchors passed as custom component props (#26360) (Mikhail Baev) - 253cdb2 linter/eslint/id-length: Exempt TS interface/type-literal members with never (#26310) (Pearce Ropion) - 8c7ea76 ast_visit: Account for trimmed source offsets (#26223) (Cameron) - 5f9cffc linter/typescript/no-explicit-any: Fix rest parameter to `unknown[]` (#26279) (camc314) - 4de9fa3 linter/react/jsx-no-literals: Check nested JSX expression literals (#26253) (camc314) - 07851b9 parser: Fix debug assert failure when lexer error with tokens enabled (#26229) (overlookmotel) - 9cee146 oxlint/lsp: Don't try to parse fix message, always fallback (#26204) (Sysix) - a662c40 linter/eslint/no-useless-assignment: Handle destructuring assignments (#25925) (camc314) - 304bd9a linter/eslint/no-array-constructor: Handle ASI hazards in fixer (#26166) (Hamody We) - b41bb35 linter: Qualify rules in rules output (#26250) (camc314) - 895c685 linter/typescript/no-extraneous-class: Avoid deleting class expressions (#26231) (camc314) - 4ba33c8 linter/eslint/no-unused-vars: Handle stored arrow references (#26225) (camc314) ### 🛡️ Security - 9a612d5 deps: Update npm packages (#26178) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 2c9a947 parser: [**BREAKING**] Reduce `MAX_LEN` to 256 bytes below `u32::MAX` (#26352) (overlookmotel) ### 🚀 Features - 68e12ab formatter_css: Follow the oxc-css-parser's acceptance line (#26337) (leaysgur) ### 🐛 Bug Fixes - f7acdc0 formatter: Treat a JSDoc cast target as opaque in chain layouts (#26375) (leaysgur) - 104061b formatter: Keep JSDoc cast parens with a comment inside them (#26374) (leaysgur) - 3d00a76 formatter_css: Keep comment inside important and simple-vars colon (#26370) (leaysgur) - 172ddb6 formatter_css: Keep a same-line line comment on its line (#26321) (leaysgur) - cafaf32 formatter_css: Never drop comments inside an at-rule prelude (#26320) (leaysgur) - 534a0fe formatter_css: Keep a line comment on its comma's line (#26319) (leaysgur) - 99cfd75 formatter_css: Hide raw comment printing API, use strcut instead (#26316) (leaysgur) - 2028896 formatter_css: Preserve comments around SCSS/Less variable values (#26276) (leaysgur) - 6752abc formatter_css: Keep leading comments before (#26272) (leaysgur) - 3b054de formatter_graphql: Align comment printing after open `{` (#26271) (leaysgur) - b3c287a formatter_css: Fix SCSS bracket list printing (#26270) (leaysgur) - bac770a formatter_css: Preserve comment in SCSS paren comma list (#26269) (leaysgur) - c7b57ef formatter_css: Print SCSS map consisntent with and without comment (#26268) (leaysgur) - 063e2b6 formatter_css: Preserve trailing comma in single-item scss lists (#26245) (leaysgur) - 5f9580d oxfmt: Bump prettier-plugin-tailwindcss (#26273) (leaysgur) ### ⚡ Performance - 1cad286 oxfmt: Match editorconfig once per file (#26239) (Yuji Sugiura) - 260c5eb oxfmt: Match `overrides` once per file (#26238) (leaysgur) - 61565bc oxfmt: Share resolved `FormatConfig` via `Arc` instead of cloning per file (#26237) (leaysgur) ### 📚 Documentation - 32084d4 formatter_core: Clarify printer hard_line compression (#26312) (leaysgur) - 4fabdcc formatter,formatter_css,formatter_graphql,formatter_yaml: Update DIVERGENCES.md (#26267) (leaysgur) - 26a1fa4 formatter_core: Refine FORMATTER_POLICY (#26266) (leaysgur) ### 🛡️ Security - 9a612d5 deps: Update npm packages (#26178) (renovate[bot])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
id-lengthlint rule lets users opt out of checking property name lengths via aproperties: "never"setting. This exemption worked correctly for plain JavaScript object properties, but was silently ignored for TypeScript interface members and object type literal members. As a result, users who explicitly disabled property length checks would still see false-positive warnings on their TypeScript type definitions.Why
TypeScript interfaces and type literals describe object shapes using their own dedicated syntax, distinct from JavaScript object literals. The rule's internal logic only recognized the JavaScript form when deciding whether to skip the length check, so the TypeScript equivalents were treated as ordinary identifiers instead of property names, even though users intended the same exemption to apply to both.
Changes
properties: "never"setting applies to them consistently with plain JavaScript object properties.Test plan
AI disclosure
Per the repo's AI usage policy: this fix was drafted with AI assistance (Claude), and reviewed, tested, and understood by me before submission. The linked issue itself was also AI-drafted and reviewed by me.
Resolves #26309