Repository navigation
Removed some dead workspace tests - #17582
Merged
Merged
Conversation
Collaborator
|
r? @Muscraft rustbot has assigned @Muscraft. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
hmmm, same CI failure as #17580. Re-running. |
weihanglo
approved these changes
Oct 12, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 14, 2026
Update cargo submodule 14 commits in 29c5daa1afc262323364e039bb70c83372cc702c..3960fa69bb617e3d93c4ddc087c1b32bf12ad907 2026-10-07 22:13:48 +0000 to 2026-10-12 19:29:05 +0000 - refactor: modernize some API usages for 1.99 (rust-lang/cargo#17584) - Removed some dead workspace tests (rust-lang/cargo#17582) - Bypass rustup proxy when RUSTUP_TOOLCHAIN is an absolute path (rust-lang/cargo#17562) - chore: Add an LLM disclosure to the PR template (rust-lang/cargo#17580) - Restrict workspace-relative dep-info to workspace packages (rust-lang/cargo#17575) - fix(layout): exclude a build-dir created as a parent from backups (rust-lang/cargo#17560) - Avoid absolute paths in fingerprints if they are relative to the workspace root (rust-lang/cargo#17573) - chore(deps): update msrv (3 versions) to v1.97 (rust-lang/cargo#17572) - fix(job): Allow explicit child process breakaway on Windows (rust-lang/cargo#17527) - fix(git): Add future-incompat warning in prep for removing auto-detection (rust-lang/cargo#17568) - fix(config): Don't process includes for `credentials.toml` files (rust-lang/cargo#17569) - doc(builtin-dep): Document the builtin package ID spec format (rust-lang/cargo#17564) - test(mock-std): Set stable crate versions to 0.0.0 (rust-lang/cargo#17565) - Fix: cargo installing from a directory source fails for binary packages with no dependencies. (rust-lang/cargo#17552) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 14, 2026
Update cargo submodule 14 commits in 29c5daa1afc262323364e039bb70c83372cc702c..3960fa69bb617e3d93c4ddc087c1b32bf12ad907 2026-10-07 22:13:48 +0000 to 2026-10-12 19:29:05 +0000 - refactor: modernize some API usages for 1.99 (rust-lang/cargo#17584) - Removed some dead workspace tests (rust-lang/cargo#17582) - Bypass rustup proxy when RUSTUP_TOOLCHAIN is an absolute path (rust-lang/cargo#17562) - chore: Add an LLM disclosure to the PR template (rust-lang/cargo#17580) - Restrict workspace-relative dep-info to workspace packages (rust-lang/cargo#17575) - fix(layout): exclude a build-dir created as a parent from backups (rust-lang/cargo#17560) - Avoid absolute paths in fingerprints if they are relative to the workspace root (rust-lang/cargo#17573) - chore(deps): update msrv (3 versions) to v1.97 (rust-lang/cargo#17572) - fix(job): Allow explicit child process breakaway on Windows (rust-lang/cargo#17527) - fix(git): Add future-incompat warning in prep for removing auto-detection (rust-lang/cargo#17568) - fix(config): Don't process includes for `credentials.toml` files (rust-lang/cargo#17569) - doc(builtin-dep): Document the builtin package ID spec format (rust-lang/cargo#17564) - test(mock-std): Set stable crate versions to 0.0.0 (rust-lang/cargo#17565) - Fix: cargo installing from a directory source fails for binary packages with no dependencies. (rust-lang/cargo#17552) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I came across these tests and out of curiosity I looked up their history.
It appears they have been commented out since the first commit (f320997) they were added 9 years ago.
I'd argue it's better to remove them instead of letting them bitrot for another decade :P
How to test and review this PR?
just removed commented out code