Repository navigation
script: Expand supports() validation coverage in WebCrypto - #47545
Merged
Merged
Conversation
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
mrobinson
reviewed
Sep 1, 2026
| // Step 2. | ||
| // Step 2. Let keyData be the key data to be imported. | ||
|
|
||
| // Step 3. |
Member
There was a problem hiding this comment.
Do you mind putting the spec text here as well?
Member
Author
There was a problem hiding this comment.
https://w3c.github.io/webcrypto/#ecdsa-operations-import-key
Step 3 consists of a long list of sub-steps, which are already included below. (However, the if-clauses of step 3 are missing, and I added them right above each match-arms.)
| public_exponent | ||
| .iter() | ||
| .skip_while(|byte| **byte == 0) | ||
| .all(|byte| *byte == 255) |
Member
There was a problem hiding this comment.
Does this work for values of modulus_length isn't a multiple of 8?
Member
Author
There was a problem hiding this comment.
Nice finding! It won't work when modulus_length is not a multiple of 8.
I rewrote this part. Now we don't calculate the public exponent length in bits. This implementation should be more straightforward.
TIL: we can get 255u8 by 0u8.wrapping_sub(1).
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
mrobinson
approved these changes
Sep 1, 2026
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…7545) WebCrypto API specification has updated some cryptography operations in order to expand `supports()` validation coverage. We follow the updates. The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective. Meanwhile, since the actually implementation of Step 8 of the **check support for an algorithm** algorithm is based on how these operations are written, and it follows the above changes, the `supports()` method, which relies on the **check support for an algorithm** algorithm, improves its validation coverage. We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74. Spec Update: w3c/webcrypto#558 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…7545) WebCrypto API specification has updated some cryptography operations in order to expand `supports()` validation coverage. We follow the updates. The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective. Meanwhile, since the actually implementation of Step 8 of the **check support for an algorithm** algorithm is based on how these operations are written, and it follows the above changes, the `supports()` method, which relies on the **check support for an algorithm** algorithm, improves its validation coverage. We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74. Spec Update: w3c/webcrypto#558 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebCrypto API specification has updated some cryptography operations in order to expand
supports()validation coverage. We follow the updates.The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective.
Meanwhile, since the actually implementation of Step 8 of the check support for an algorithm algorithm is based on how these operations are written, and it follows the above changes, the
supports()method, which relies on the check support for an algorithm algorithm, improves its validation coverage.We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74.
Spec Update: w3c/webcrypto#558
WPT Update: web-platform-tests/wpt#62115
Testing: Pass more WPT tests.