Repository navigation
[WebCryptoAPI] Expand supports() validation coverage - #62115
Merged
panva merged 1 commit intoAug 21, 2026
Merged
Conversation
Keep ECDH mismatched-curve cases independent of the existing overlength deriveBits tests. Add supports() coverage for RSA, HKDF, HMAC, EC derivation and import, ML-DSA contexts, and ML-KEM imported keys. Refs: w3c/webcrypto#560 Refs: w3c/webcrypto#558 Refs: WICG/webcrypto-modern-algos#76 Refs: WICG/webcrypto-modern-algos#77
twiss
approved these changes
Aug 21, 2026
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Sep 1, 2026
…7545) WebCrypto API specification has updated some cryptography operations in order to expand `supports()` validation coverage. We follow the updates. The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective. Meanwhile, since the actually implementation of Step 8 of the **check support for an algorithm** algorithm is based on how these operations are written, and it follows the above changes, the `supports()` method, which relies on the **check support for an algorithm** algorithm, improves its validation coverage. We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74. Spec Update: w3c/webcrypto#558 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
lumiscosity
pushed a commit
to lumiscosity/servo
that referenced
this pull request
Sep 3, 2026
Modern Algorithm in WebCrypto API specification has updated the sign and verify operations of ML-DSA, in order to improve `supports()` method validation coverage. We follow the update to add a step to check the context length at the beginning of the sign and verify operations of ML-DSA. The implementation of Step 8 of the **check support for an algorithm** algorithm also follows these changes. Spec Update: WICG/webcrypto-modern-algos#76 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
…7545) WebCrypto API specification has updated some cryptography operations in order to expand `supports()` validation coverage. We follow the updates. The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective. Meanwhile, since the actually implementation of Step 8 of the **check support for an algorithm** algorithm is based on how these operations are written, and it follows the above changes, the `supports()` method, which relies on the **check support for an algorithm** algorithm, improves its validation coverage. We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74. Spec Update: w3c/webcrypto#558 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Oct 6, 2026
Modern Algorithm in WebCrypto API specification has updated the sign and verify operations of ML-DSA, in order to improve `supports()` method validation coverage. We follow the update to add a step to check the context length at the beginning of the sign and verify operations of ML-DSA. The implementation of Step 8 of the **check support for an algorithm** algorithm also follows these changes. Spec Update: WICG/webcrypto-modern-algos#76 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
…7545) WebCrypto API specification has updated some cryptography operations in order to expand `supports()` validation coverage. We follow the updates. The update basically consists of moving all parameter validation to the beginning of the operations, and adding some new parameter validation which were done implicitly. Therefore, these operations should not have observable changes from user perspective. Meanwhile, since the actually implementation of Step 8 of the **check support for an algorithm** algorithm is based on how these operations are written, and it follows the above changes, the `supports()` method, which relies on the **check support for an algorithm** algorithm, improves its validation coverage. We also update our comment next to Step 8 based on the discussion in WICG/webcrypto-modern-algos#74. Spec Update: w3c/webcrypto#558 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Psychpsyo
pushed a commit
to Psychpsyo/servo
that referenced
this pull request
Oct 12, 2026
Modern Algorithm in WebCrypto API specification has updated the sign and verify operations of ML-DSA, in order to improve `supports()` method validation coverage. We follow the update to add a step to check the context length at the beginning of the sign and verify operations of ML-DSA. The implementation of Step 8 of the **check support for an algorithm** algorithm also follows these changes. Spec Update: WICG/webcrypto-modern-algos#76 WPT Update: web-platform-tests/wpt#62115 Testing: Pass more WPT tests. Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep ECDH mismatched-curve cases independent of the existing overlength deriveBits tests. Add supports() coverage for RSA, HKDF, HMAC, EC derivation and import, ML-DSA contexts, and ML-KEM imported keys.
Refs: w3c/webcrypto#560
Refs: w3c/webcrypto#558
Refs: WICG/webcrypto-modern-algos#76
Refs: WICG/webcrypto-modern-algos#77