Adds proposed popover and related attributes by scottaohara · Pull Request #446 · w3c/html-aam

scottaohara · 2022-11-28T17:26:47Z

See https://open-ui.org/components/popup.research.explainer and https://github.com/w3c/html-aam/wiki/HTML-Popover-Attribute-A11y-Proposal-(manual-and-auto)

Adds the following proposed attributes:

popover
popoverhidetarget
popovershowtarget
popovertoggletarget

Preview | Diff

See https://open-ui.org/components/popup.research.explainer and https://github.com/w3c/html-aam/wiki/HTML-Popover-Attribute-A11y-Proposal-(manual-and-auto) Adds the following proposed attributes: - `defaultopen` - `popover` - `popoverhidetarget` - `popovershowtarget` - `popovertoggletarget`

I failed to remember this was not being included in v1 of `popover`, so taking this out of the PR.

The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446

scottaohara · 2022-12-11T23:21:48Z

TODOs to complete this PR:

Separate PR for Minimum Role needs to be completed.
ispopup object attribute for ia2/atk
for popover=manual, there may be additional mappings related to aria-details which would need to also be mapped to the triggering element, if there is one / applicable.

The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446

annevk · 2023-02-23T18:39:00Z

It might be good to wait for whatwg/html#8894.

Also, I'm glad this work is already underway! Next time we add new semantics to HTML I'll try to make sure this is considered as part of the main HTML PR. As in, ensure the work is coordinated and can land around the same time.

* initial astro commit * minor config change * move over sources * fix prettier formatting * rename files and create layout * move to markdown * migrate markdown file * get navigation working * fix routing for pages * update the documentation * more fixes to styling * get layouts working for all pages * improve styles even more * get build working * fix image * fix navigation order * get navigation working * add favicon * fix page title * fix menu sorting * fix lighthouse issues * update node version * minors to styles * override gatsby build config * typo * fix navigation styles * remove unused dependencies, remove render blocking resources, prefetch resources * reduce font flashing, fix markup issues * fix build from breaking * test removing prefetch * rmeove compression * revert changes to config * fix prefetch * fix image paths * Create 2022-12-01.md * Update 2022-12-01.md * Update 2022-12-01.md * Update popup.research.explainer.mdx (#644) Remove lingering mention of `popover=hint` for now. * Popover target attribute updates (#647) The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446 * Create 2023-01-05.md * Update 2023-01-05.md * Create 2023-01-12.md * docs: add kolibri accessible component lib (#624) * Update 2023-01-12.md * Create 2023-01-19.md * Task: Add redirect for popup (#653) * add redirect for popup * refactor code * let yarn do its thing * revert formatting change * add redirect comment Co-authored-by: Andrico <andrico@animaapp.com> * Update popover.research.explainer.mdx (#654) * Update popover.research.explainer.mdx * Update research/src/pages/popup/popover.research.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Create 2023-02-02.md * fix layout issue * fix interactions * Update 2023-02-02.md * Update 2023-02-02.md * selectmenu is an element, code escape it (#660) * update layout and remove stale content * handle missing images * minor fixes and redirects * fix dead links * Create 2023-02-16.md * Update 2023-02-16.md * Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663) * Create 2023-02-23.md * minor improvements * temporarily prevent refetch * revert prefetch change * Update 2023-02-23.md * performance + a11y improvements * remove Lora font family --------- Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com>

* [Site rewrite] Migrate site to astro (#606) * initial astro commit * minor config change * move over sources * fix prettier formatting * rename files and create layout * move to markdown * migrate markdown file * get navigation working * fix routing for pages * update the documentation * more fixes to styling * get layouts working for all pages * improve styles even more * get build working * fix image * fix navigation order * get navigation working * add favicon * fix page title * fix menu sorting * fix lighthouse issues * update node version * minors to styles * override gatsby build config * typo * fix navigation styles * remove unused dependencies, remove render blocking resources, prefetch resources * reduce font flashing, fix markup issues * fix build from breaking * test removing prefetch * rmeove compression * revert changes to config * fix prefetch * fix image paths * Create 2022-12-01.md * Update 2022-12-01.md * Update 2022-12-01.md * Update popup.research.explainer.mdx (#644) Remove lingering mention of `popover=hint` for now. * Popover target attribute updates (#647) The `popovertoggletarget`, `popovershowtarget` and `popoverhidetarget` attributes will initially map to `aria-expanded`. This has already been implemented in Chromium browsers. HTML AAM PR to add this mapping to the spec: w3c/html-aam#446 * Create 2023-01-05.md * Update 2023-01-05.md * Create 2023-01-12.md * docs: add kolibri accessible component lib (#624) * Update 2023-01-12.md * Create 2023-01-19.md * Task: Add redirect for popup (#653) * add redirect for popup * refactor code * let yarn do its thing * revert formatting change * add redirect comment Co-authored-by: Andrico <andrico@animaapp.com> * Update popover.research.explainer.mdx (#654) * Update popover.research.explainer.mdx * Update research/src/pages/popup/popover.research.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Create 2023-02-02.md * fix layout issue * fix interactions * Update 2023-02-02.md * Update 2023-02-02.md * selectmenu is an element, code escape it (#660) * update layout and remove stale content * handle missing images * minor fixes and redirects * fix dead links * Create 2023-02-16.md * Update 2023-02-16.md * Adjusted the home page to reflect the current reality and ensure the relationship between Open UI & the W3C is clear (#663) * Create 2023-02-23.md * minor improvements * temporarily prevent refetch * revert prefetch change * Update 2023-02-23.md * performance + a11y improvements * remove Lora font family --------- Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Greg Whitworth <865244+gregwhitworth@users.noreply.github.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com> * remove unused dependencies --------- Co-authored-by: Andrico <karoulla.andrico@gmail.com> Co-authored-by: Andrico <andrico.karoulla@healthhero.com> Co-authored-by: Jhey Tompkins <jh3y@users.noreply.github.com> Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Martin <6279703+deleonio@users.noreply.github.com> Co-authored-by: Andrico <andrico@animaapp.com> Co-authored-by: Tantek Çelik <blog@tantek.com>

annevk · 2023-03-01T21:01:10Z

whatwg/html#8962 resolves the issue I mentioned earlier so that will require some changes here.

One thing that seems somewhat awkward here is that certain requirements of HTML are restated. Ideally we'd build upon the model that HTML establishes so we don't have to make requirements as to when certain buttons are ignored for instance.

scottaohara · 2023-03-01T21:36:07Z

thanks for the heads up @annevk. i'll review the changes and make updates.

also agree, i can cut out requirements that are already defined in HTML. I was working on this in tandem with the original PR for the attributes, so this can be revised to remove redundancies.

Instead of popoverhidetarget, popovershowtarget, and popovertoggletarget, we will now have popovertarget and popovertargetaction. The former for targeting an element and the latter for determining what to do with the target. This also corrects popover validity checks in activation behavior and consistifies the popover attribute. Tests: web-platform-tests/wpt#38701. HTML-AAM: w3c/html-aam#446. Fixes #8894, fixes #8983, and fixes #8979.

this commit supersedes #446 TODO: finalize `popover` attribute mappings

scottaohara · 2023-05-09T00:48:11Z

closing this per new PR #481

scottaohara commented Nov 28, 2022

View reviewed changes

Comment thread index.html Outdated

Update index.html

6832e03

scottaohara requested a review from aleventhal November 28, 2022 17:37

remove defaultopen from PR

fd0024e

I failed to remember this was not being included in v1 of `popover`, so taking this out of the PR.

mfreed7 reviewed Nov 28, 2022

View reviewed changes

Comment thread index.html Outdated

scottaohara added 2 commits November 28, 2022 14:33

Update index.html

723091d

Merge branch 'gh-pages' into popover-attrs

7fb0fd3

jnurthen marked this pull request as draft December 1, 2022 18:09

remove comments

ae3911c

scottaohara mentioned this pull request Dec 11, 2022

Popover target attribute updates openui/open-ui#647

Merged

Merge branch 'gh-pages' into popover-attrs

234a374

mfreed7 mentioned this pull request Dec 13, 2022

[popover] are popovertoggletarget, popovershowtarget and popoverhidetarget needed? openui/open-ui#646

Closed

spectranaut mentioned this pull request Feb 23, 2023

Mappings for HTML's popover attribute w3c/core-aam#165

Closed

Merge branch 'gh-pages' into popover-attrs

c8b66f5

gregwhitworth mentioned this pull request Feb 27, 2023

[Site rewrite] Migrate site to astro (#606) openui/open-ui#667

Merged

scottaohara added a commit that referenced this pull request May 9, 2023

revise popover related attribute mappings

39ae862

this commit supersedes #446 TODO: finalize `popover` attribute mappings

scottaohara mentioned this pull request May 9, 2023

add/revise popover related attribute mappings #481

Closed

scottaohara closed this May 9, 2023

Navigation Menu

Repository navigation

Adds proposed popover and related attributes - #446

Adds proposed popover and related attributes#446
scottaohara wants to merge 8 commits into
gh-pagesfrom
popover-attrs

scottaohara commented Nov 28, 2022 •

edited by pr-preview Bot

Loading

Uh oh!

Uh oh!

Uh oh!

scottaohara commented Dec 11, 2022

Uh oh!

annevk commented Feb 23, 2023

Uh oh!

annevk commented Mar 1, 2023

Uh oh!

scottaohara commented Mar 1, 2023

Uh oh!

scottaohara commented May 9, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

scottaohara commented Nov 28, 2022 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scottaohara commented Dec 11, 2022

Uh oh!

annevk commented Feb 23, 2023

Uh oh!

annevk commented Mar 1, 2023

Uh oh!

scottaohara commented Mar 1, 2023

Uh oh!

scottaohara commented May 9, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

scottaohara commented Nov 28, 2022 •

edited by pr-preview Bot

Loading