Repository navigation
HTML: test queueing behavior of window.close() - #15649
Merged
Merged
Conversation
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
March 4, 2019 11:06
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1533416 on Firefox. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 7, 2019
close() needed to queue a task to close, though closed needs to immediately know when close() is invoked too. Tests: web-platform-tests/wpt#15561 & web-platform-tests/wpt#15649. Fixes #4405. Helps with #4363.
domenic
reviewed
Mar 7, 2019
domenic
left a comment
Member
There was a problem hiding this comment.
I think it's worth trying to use events instead of timeouts, if we can.
Member
Author
|
Thanks, events do indeed work due to this being same-origin. |
Member
Author
|
Safari bug is referenced from whatwg/html#4402. |
domenic
approved these changes
Mar 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason the second test fails in Firefox is due to
window.open()using a nested event loop. I could make Firefox pass the test by removing theopenee.openerassert, but seems bad?