Skip to content

feat(minifier): expand de morgan's optimization to allow move of ! - #25930

Merged
Dunqing merged 3 commits into
oxc-project:mainfrom
armano2:feat/de-morgan-changes
Aug 28, 2026
Merged

feat(minifier): expand de morgan's optimization to allow move of !#25930
Dunqing merged 3 commits into
oxc-project:mainfrom
armano2:feat/de-morgan-changes

Conversation

@armano2

@armano2 armano2 commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Expand negation to include move of ! operator to inner children

!(a == b && c == 3 && a)
a != b || c != 3 | !a

delta calculation is dependent on boolean context

  • if we expect truthly/falsly value negation of !a will be converted to a (-1 delta)
  • in ambiguous context !a will be converted to !!a (+1 delta)
a = !!(!b || !c);
//   ^ ^     ^ -3
a = !(b || c)
//  ^ ^    ^ +1 - if we could detect if parens can be removed it would be -1
//  ^^^    ^^ -1 - if we would know that we can remove parens

ref #25294

@codspeed

codspeed Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing armano2:feat/de-morgan-changes (605476a) with main (d5163d0)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (de31acc) during the generation of this report, so d5163d0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@armano2
armano2 force-pushed the feat/de-morgan-changes branch from 47bf089 to 6e5a22d Compare August 20, 2026 22:31
@armano2
armano2 force-pushed the feat/de-morgan-changes branch from 6e5a22d to 9316821 Compare August 23, 2026 14:45
@armano2 armano2 changed the title feat(minifier): expand de morgan's optimization to allow move not feat(minifier): expand de morgan's optimization to allow move of ! Aug 24, 2026
armano2
armano2 commented Aug 24, 2026
View reviewed changes
Comment thread crates/oxc_minifier/tests/peephole/esbuild.rs
armano2
armano2 commented Aug 24, 2026
View reviewed changes
Comment thread crates/oxc_minifier/src/peephole/minimize_not_expression.rs
@armano2
armano2 marked this pull request as ready for review August 24, 2026 09:03
armano2
armano2 commented Aug 24, 2026
View reviewed changes
Comment thread crates/oxc_minifier/src/peephole/minimize_not_expression.rs
@armano2
armano2 marked this pull request as draft August 24, 2026 11:14
@armano2
armano2 marked this pull request as ready for review August 25, 2026 14:42
@Dunqing

Dunqing commented Aug 26, 2026

Copy link
Copy Markdown
Member

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 931682141c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/oxc_minifier/src/peephole/minimize_not_expression.rs Outdated
Dunqing
Dunqing approved these changes Aug 26, 2026
View reviewed changes

@Dunqing Dunqing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Dunqing

Dunqing commented Aug 26, 2026

Copy link
Copy Markdown
Member

/monitor-oxc run

@oxc-guard

oxc-guard Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Monitor Oxc

Commit: 931682141c96

suite result
Build ✅
Test262 ✅
Isolated Declarations ✅
Uglify Corpus ✅
Runtime Bundles ✅
(dce) ✅
(compressor) ✅
(whitespace) ✅
(transformer) ✅
(codegen) ✅
(mangler) ❌
(formatter) ❌
(formatter_dcr) ✅
Runtime (zod) ❌
Runtime (vue) ✅
Runtime (solid) ✅
Runtime (svelte) ✅
Runtime (es-toolkit) ✅

@Dunqing

Dunqing commented Aug 28, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 605476a9cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dunqing
Dunqing merged commit 3ed4f6a into oxc-project:main Aug 28, 2026
38 checks passed
@armano2
armano2 deleted the feat/de-morgan-changes branch August 28, 2026 19:09
@oxc-guard oxc-guard Bot mentioned this pull request Aug 31, 2026
Merged
graphite-app Bot pushed a commit that referenced this pull request Sep 1, 2026
@oxc-guard
release(crates): oxc v0.148.0 (#26198)
894c8f9 
### 💥 BREAKING CHANGES

- a31567a allocator: [**BREAKING**] Make `Allocator::cursor_ptr` and `data_end_ptr` private (#26081) (overlookmotel)

### 🚀 Features

- 784e9fa minifier: Invert `!0` and `!1` in place for boolean context to `1` and `0` (#26050) (Armano)
- 1e902cc minifier: Expand fold leading assignments into the var decl (#26142) (Armano)
- 3ed4f6a minifier: Expand de morgan's optimization to allow move of `!` (#25930) (Armano)
- 5672585 parser: Attach all comments to nodes (#25944) (camc314)

### 🐛 Bug Fixes

- 4adfb4c semantic: Validate chained continue labels (#26157) (camc314)
- b874f48 ecmascript: `Math.round` only exact half ties (#26150) (camc314)
- a625378 minifier: Coerce omitted `indexOf` search argument (#26149) (camc314)
- dc7398b ecmascript: Trim trailing whitespace in string to number (#26148) (camc314)
- 243b685 transformer/object-rest: Lower multiple declarators correctly (#26147) (camc314)
- dc09a3a parser: Avoid panic on escaped string export names (#26146) (camc314)
- e412cf2 linter: Clamp invalid JS plugin locations (#26144) (camc314)
- c3dedc9 semantic: Skip function body bindings in parameters (#26099) (Dunqing)
- e74de61 transform-react: Match Babel diagnostic reporting (#26128) (Boshen)
- d5163d0 parser: Correctly classify unapplied pure annotations (#26084) (camc314)
- 8531b9b linter/plugins: Alter method for obtaining mutable `Program` when sending AST to JS plugins (#26077) (overlookmotel)
- 9b51658 regular_expression: Allow oversized decimal escape for Annex B (#26070) (leaysgur)
- c8de4df regular_expression: Reject oversized backreferences (#26055) (camc314)

### ⚡ Performance

- ac4785a diagnostics: Use fixed ANSI styles (#26130) (Boshen)
- 07a0793 packages/codegen: Flatten output in chunks (#26109) (overlookmotel)
- 487427a packages/codegen: Faster string flattening (#26108) (overlookmotel)
- 7785583 packages/codegen: Ensure indent strings are flattened (#26107) (overlookmotel)
- 0dd4db3 packages/codegen: Store mapping positions in an `Int32Array` (#26085) (overlookmotel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@overlookmotel overlookmotel Awaiting requested review from overlookmotel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armano2 @Dunqing
Sponsor
SponsoredKunjungi sekarang
Promo