fix(transformer/object-rest): lower multiple declarators correctly - #26147
Merged
graphite-app[bot] merged 1 commit intoAug 28, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
…26147) ## Summary Fix ES2018 object-rest lowering when one variable declaration contains multiple object-rest declarators. ### Before Given: ```js let { a, ...r } = x, { b, ...s } = y; ``` Oxc produced: ```js let { a } = x, { b } = y, s = babelHelpers.objectWithoutProperties(y, ["b"]), {} = null; ``` The `r` binding was lost. Each replacement was recorded using its original declarator index. Replacing the first declarator expanded it into multiple entries, shifting the second declarator. The subsequent replacement still used the old index and overwrote part of the first expansion. ### After Oxc now produces: ```js let { a } = x, r = babelHelpers.objectWithoutProperties(x, ["a"]), { b } = y, s = babelHelpers.objectWithoutProperties(y, ["b"]); ``` Queued replacements are applied from right to left. Replacing a later declarator cannot change the index of an earlier one, so every recorded index remains valid. Regression coverage includes multiple `let`, `const`, and `var` declarators.
graphite-app
Bot
force-pushed
the
codex/fix-object-rest-multiple-declarators
branch
from
August 28, 2026 14:02
138a1c7 to
243b685
Compare
graphite-app
Bot
deleted the
codex/fix-object-rest-multiple-declarators
branch
August 28, 2026 14:07
graphite-app Bot
pushed a commit
that referenced
this pull request
Sep 1, 2026
### 💥 BREAKING CHANGES - a31567a allocator: [**BREAKING**] Make `Allocator::cursor_ptr` and `data_end_ptr` private (#26081) (overlookmotel) ### 🚀 Features - 784e9fa minifier: Invert `!0` and `!1` in place for boolean context to `1` and `0` (#26050) (Armano) - 1e902cc minifier: Expand fold leading assignments into the var decl (#26142) (Armano) - 3ed4f6a minifier: Expand de morgan's optimization to allow move of `!` (#25930) (Armano) - 5672585 parser: Attach all comments to nodes (#25944) (camc314) ### 🐛 Bug Fixes - 4adfb4c semantic: Validate chained continue labels (#26157) (camc314) - b874f48 ecmascript: `Math.round` only exact half ties (#26150) (camc314) - a625378 minifier: Coerce omitted `indexOf` search argument (#26149) (camc314) - dc7398b ecmascript: Trim trailing whitespace in string to number (#26148) (camc314) - 243b685 transformer/object-rest: Lower multiple declarators correctly (#26147) (camc314) - dc09a3a parser: Avoid panic on escaped string export names (#26146) (camc314) - e412cf2 linter: Clamp invalid JS plugin locations (#26144) (camc314) - c3dedc9 semantic: Skip function body bindings in parameters (#26099) (Dunqing) - e74de61 transform-react: Match Babel diagnostic reporting (#26128) (Boshen) - d5163d0 parser: Correctly classify unapplied pure annotations (#26084) (camc314) - 8531b9b linter/plugins: Alter method for obtaining mutable `Program` when sending AST to JS plugins (#26077) (overlookmotel) - 9b51658 regular_expression: Allow oversized decimal escape for Annex B (#26070) (leaysgur) - c8de4df regular_expression: Reject oversized backreferences (#26055) (camc314) ### ⚡ Performance - ac4785a diagnostics: Use fixed ANSI styles (#26130) (Boshen) - 07a0793 packages/codegen: Flatten output in chunks (#26109) (overlookmotel) - 487427a packages/codegen: Faster string flattening (#26108) (overlookmotel) - 7785583 packages/codegen: Ensure indent strings are flattened (#26107) (overlookmotel) - 0dd4db3 packages/codegen: Store mapping positions in an `Int32Array` (#26085) (overlookmotel)
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ES2018 object-rest lowering when one variable declaration contains multiple object-rest declarators.
Before
Given:
Oxc produced:
The
rbinding was lost.Each replacement was recorded using its original declarator index. Replacing the first declarator expanded it into multiple entries, shifting the second declarator. The subsequent replacement still used the old index and overwrote part of the first expansion.
After
Oxc now produces:
Queued replacements are applied from right to left. Replacing a later declarator cannot change the index of an earlier one, so every recorded index remains valid.
Regression coverage includes multiple
let,const, andvardeclarators.