fix(parser): correctly classify unapplied pure annotations by camc314 · Pull Request #26084 · oxc-project/oxc

camc314 · 2026-08-25T13:16:32Z

Mark all #__PURE__ annotations not directly applied to a NewExpression or CallExpressionasPureNotApplied`.

This changes the approach by letting pure annotations start of their life as CommentContent::PureNotApplied, and only changing to CommentContent::Pure once they have successfully been applied to a node.

This aligns the behaviour with Rollup.

Rollup Playground:

https://rollupjs.org/repl/?version=4.63.0&shareable=eyJleGFtcGxlIjpudWxsLCJtb2R1bGVzIjpbeyJjb2RlIjoidmFyIGZvbyAvKiAjX19QVVJFX18gKi8gPSBwdXJlT3BlcmF0aW9uKCk7XG5mb28gLyogI19fUFVSRV9fICovID0gcHVyZU9wZXJhdGlvbigpO1xuZm9vIC8qICNfX1BVUkVfXyAqLyArIHB1cmVPcGVyYXRpb24oKTtcbmZvbyAvKiAjX19QVVJFX18gKi8gJiYgcHVyZU9wZXJhdGlvbigpOyIsImlzRW50cnkiOnRydWUsIm5hbWUiOiJtYWluLmpzIn1dLCJvcHRpb25zIjp7fX0=

Rolldown Playground: (only the 1st pure comment is marked as not applied).

https://repl.rolldown.rs/#eNqlkU1LxDAQhv/KEGG/LO294kk8K4K3QEnbyW60nYR0uu5S+t9NUlwRPQgLgczHOy/zMJPQopyEoRZP+dsQYxLld56JJqRH5UFbC8UObqrq+fXlsapgV8A9uNHjk0Ov2FjabO+kl3Sd8vbfytXqlzTsi6JkP+KcCW+7rrUflDeWtNnnfMH7o7OAmt5ZzzBBi9oQPqQ2zKC97WH9NbaWJAlPSRqEauzSfxnYTJIADLmRS1gs8x5Z5amUQVEAHxC06XCAATtsGFuoz6laj8yWIDxUzQFY1dEsjFgXIYeY2ZGT9wS9IaPPJURkmCXNW0kisDvVvKs9hhPaALxQ/6gtvGlRKVp0GC5OjcFBiuAbnaJRcDoGWacYBxbzJ8uvunY=

fixes #23669
closes #24161

codspeed · 2026-08-25T13:23:44Z

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing c/mark-bin-expr-as-pure-not-applied (efe9360) with main (bd15905)}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2026-08-25T16:33:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d92e18022

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

camc314 · 2026-08-26T10:29:31Z

Merging, I've tested this in rolldown and can't see any regressions.

camc314 · 2026-08-26T10:29:37Z

Merge activity

Aug 26, 10:29 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Aug 26, 10:29 AM UTC: camc314 added this pull request to the Graphite merge queue.
Aug 26, 10:39 AM UTC: Merged by the Graphite merge queue.

Mark all `#__PURE__` annotations not directly applied to a `NewExpression` or CallExpression` as `PureNotApplied`. This changes the approach by letting pure annotations start of their life as `CommentContent::PureNotApplied`, and only changing to `CommentContent::Pure` once they have successfully been applied to a node. This aligns the behaviour with Rollup. Rollup Playground: https://rollupjs.org/repl/?version=4.63.0&shareable=eyJleGFtcGxlIjpudWxsLCJtb2R1bGVzIjpbeyJjb2RlIjoidmFyIGZvbyAvKiAjX19QVVJFX18gKi8gPSBwdXJlT3BlcmF0aW9uKCk7XG5mb28gLyogI19fUFVSRV9fICovID0gcHVyZU9wZXJhdGlvbigpO1xuZm9vIC8qICNfX1BVUkVfXyAqLyArIHB1cmVPcGVyYXRpb24oKTtcbmZvbyAvKiAjX19QVVJFX18gKi8gJiYgcHVyZU9wZXJhdGlvbigpOyIsImlzRW50cnkiOnRydWUsIm5hbWUiOiJtYWluLmpzIn1dLCJvcHRpb25zIjp7fX0= Rolldown Playground: (only the 1st pure comment is marked as not applied). https://repl.rolldown.rs/#eNqlkU1LxDAQhv/KEGG/LO294kk8K4K3QEnbyW60nYR0uu5S+t9NUlwRPQgLgczHOy/zMJPQopyEoRZP+dsQYxLld56JJqRH5UFbC8UObqrq+fXlsapgV8A9uNHjk0Ov2FjabO+kl3Sd8vbfytXqlzTsi6JkP+KcCW+7rrUflDeWtNnnfMH7o7OAmt5ZzzBBi9oQPqQ2zKC97WH9NbaWJAlPSRqEauzSfxnYTJIADLmRS1gs8x5Z5amUQVEAHxC06XCAATtsGFuoz6laj8yWIDxUzQFY1dEsjFgXIYeY2ZGT9wS9IaPPJURkmCXNW0kisDvVvKs9hhPaALxQ/6gtvGlRKVp0GC5OjcFBiuAbnaJRcDoGWacYBxbzJ8uvunY= fixes #23669 closes #24161

### 💥 BREAKING CHANGES - a31567a allocator: [**BREAKING**] Make `Allocator::cursor_ptr` and `data_end_ptr` private (#26081) (overlookmotel) ### 🚀 Features - 784e9fa minifier: Invert `!0` and `!1` in place for boolean context to `1` and `0` (#26050) (Armano) - 1e902cc minifier: Expand fold leading assignments into the var decl (#26142) (Armano) - 3ed4f6a minifier: Expand de morgan's optimization to allow move of `!` (#25930) (Armano) - 5672585 parser: Attach all comments to nodes (#25944) (camc314) ### 🐛 Bug Fixes - 4adfb4c semantic: Validate chained continue labels (#26157) (camc314) - b874f48 ecmascript: `Math.round` only exact half ties (#26150) (camc314) - a625378 minifier: Coerce omitted `indexOf` search argument (#26149) (camc314) - dc7398b ecmascript: Trim trailing whitespace in string to number (#26148) (camc314) - 243b685 transformer/object-rest: Lower multiple declarators correctly (#26147) (camc314) - dc09a3a parser: Avoid panic on escaped string export names (#26146) (camc314) - e412cf2 linter: Clamp invalid JS plugin locations (#26144) (camc314) - c3dedc9 semantic: Skip function body bindings in parameters (#26099) (Dunqing) - e74de61 transform-react: Match Babel diagnostic reporting (#26128) (Boshen) - d5163d0 parser: Correctly classify unapplied pure annotations (#26084) (camc314) - 8531b9b linter/plugins: Alter method for obtaining mutable `Program` when sending AST to JS plugins (#26077) (overlookmotel) - 9b51658 regular_expression: Allow oversized decimal escape for Annex B (#26070) (leaysgur) - c8de4df regular_expression: Reject oversized backreferences (#26055) (camc314) ### ⚡ Performance - ac4785a diagnostics: Use fixed ANSI styles (#26130) (Boshen) - 07a0793 packages/codegen: Flatten output in chunks (#26109) (overlookmotel) - 487427a packages/codegen: Faster string flattening (#26108) (overlookmotel) - 7785583 packages/codegen: Ensure indent strings are flattened (#26107) (overlookmotel) - 0dd4db3 packages/codegen: Store mapping positions in an `Int32Array` (#26085) (overlookmotel)