Skip to content

fix(externals): name a core module external by its key whichever spelling the code uses - #22565

Merged
alexander-akait merged 3 commits into
mainfrom
fix/node-prefix-external-module-id
Oct 9, 2026
Merged

alexander-akait merged 3 commits into
mainfrom
fix/node-prefix-external-module-id

Conversation

@alexander-akait

@alexander-akait alexander-akait commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

When code reaches one core module external through both path and node:path, both requests share one ExternalModule. The module's name, which development builds use as its id, came from whichever request was created first. That is a race, so the same build printed different code from run to run. In CI's code-size report, performance/unused-externals-variants swung by ±15 B on unrelated PRs.

A request that matches only through its other spelling is now named by the externals key it matched, so both spellings give the same module.

// externals: { path: "commonjs path" }; one file has require("path"), another import "node:path"
// before: 5,218 or 5,233 bytes, depending on which request won
__webpack_require__(/*! node:path */ "node:path");
// after: 5,218 bytes in every run
__webpack_require__(/*! node:path */ "path");

What kind of change does this PR introduce?

fix

Did you add tests for your changes?

Yes, test/configCases/externals/node-prefix-module-id. It checks the module ids of node:fs (keyed fs) and path (keyed node:path). It failed before the fix.

Does this PR introduce a breaking change?

No. A core module external reached only through the spelling other than its key now gets the key as its module id.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

n/a

Use of AI

Written with Claude Code. It traced the flaky code-size result to this race, wrote the fix and the test case, and confirmed that six builds came out the same afterwards. I reviewed the result.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ViD41i2KdwwGxrDk7yrjeD


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Core module externals now follow the configured node: prefix behavior: prefixes are added when enabled or for universal targets, removed when disabled, and otherwise preserve the spelling used in the request. Prefixed and unprefixed forms of the same core module now resolve consistently to one module ID.

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 72cb6b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • test/configCases/chunks-order/cjs/__snapshots__/ConfigCacheTest.snap is excluded by !**/*.snap, !test/**/__snapshots__/**
  • test/configCases/chunks-order/cjs/__snapshots__/ConfigTest.snap is excluded by !**/*.snap, !test/**/__snapshots__/**
  • test/configCases/concatenate-modules/commonjs-wrapped-external-new-expression/__snapshots__/ConfigCacheTest.snap is excluded by !**/*.snap, !test/**/__snapshots__/**
  • test/configCases/concatenate-modules/commonjs-wrapped-external-new-expression/__snapshots__/ConfigTest.snap is excluded by !**/*.snap, !test/**/__snapshots__/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: webpack/webpack/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6d289a26-7a3d-480e-a957-5455c5eeb13e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: webpack/webpack/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ac550123-f66d-4ab6-824a-dbe5e14a70c1

📥 Commits

Reviewing files that changed from the base of the PR and between 2b1aa54 and ba49eb6.


📒 Files selected for processing (6)
  • .changeset/030-node-prefix-external-module-id.md
  • lib/externals/ExternalModule.js
  • test/configCases/externals/node-prefix-user-externals/index.js
  • test/configCases/externals/node-prefix-user-externals/webpack.config.js
  • test/configCases/node/output-module-external/import.js
  • test/configCases/node/prefix-in-runtime/index.js

🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/030-node-prefix-external-module-id.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

ExternalModule now adds or strips the node: prefix for recognized core-module requests based on output settings. Object-form externals pass the matched core-module key as the ExternalModule user request. Tests cover prefix behavior, external availability, and require.resolveWeak IDs.

Changes

Core-module external handling

Layer / File(s) Summary
Normalize core-module request prefixes
lib/externals/ExternalModule.js, test/configCases/externals/node-prefix-user-externals/*, test/configCases/node/output-module-external/import.js, test/configCases/node/prefix-in-runtime/index.js
Recognized core-module requests gain or lose the node: prefix based on nodePrefixForCoreModules and universal targets. Tests check prefixed imports, runtime requires, and user external configurations.
Match external keys and verify module IDs
lib/externals/ExternalModuleFactoryPlugin.js, test/configCases/externals/node-prefix-module-id/*, .changeset/030-node-prefix-external-module-id.md
handleExternal accepts an optional userRequest, which defaults to originalRequest. When an object external matches an alternate core-module spelling, the matched key is passed to ExternalModule. The config case checks external availability and require.resolveWeak IDs. The changeset records a patch release.

Suggested reviewers: hai-x


Priority: ➖ Normal

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ba49e

Core-module external requests use the configured spelling, and alternate external keys produce stable module IDs. No concrete merge-blocking risk was identified; the change appears ready to merge.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title uses the required Conventional Commit format, uses the allowed type "fix", and accurately describes the core-module external naming change.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Generated code size

Comparing base (01ee7b7) to head (72cb6b9). Merging this pull request changes the size of 564 asset(s) whose tests it leaves untouched, moves 13 asset(s) whose tests it edits too and adds 2 new asset(s).

What moved Tests Assets Gzip Raw Test edit
Changed, test untouched 332 564 🔴 ↑ +5.70 KiB 🔴 ↑ +13.74 KiB —
Changed, test edited 4 13 🔴 ↑ +96 B 🔴 ↑ +1.03 KiB 🔴 ↑ +2.06 KiB
New 2 2 ⚪ added +1.61 KiB ⚪ added +4.44 KiB —
Deleted 0 0 — — —
Unchanged — 7764 — — —

Read Changed, test untouched first: the test is byte-identical on both sides, so webpack generated the difference. Changed, test edited moved partly because the test did — Test edit is how many bytes the test gained, and a bundle that grew by less is not a regression. New and Deleted are whole files, not deltas — a new asset was created, not grown, so it reads gray (⚪ added) — and adding tests cannot bury a real change. Gzip decides, because that is what users download; raw is the tiebreak, and brotli and zstd are per asset below.

564 asset(s) changed size, test untouched, biggest 20 by raw or gzip change
Asset Before After Change Gzip (9) Brotli (11) Zstd (19)
🔴 ↑ asset-modules/url-module-analyzable bundle0.mjs 3.82 KiB 3.92 KiB +99 B (+2.53%) +36 B (+2.81%) +15 B (+1.35%) +37 B (+2.87%)
🔴 ↑ asset-modules/query-suffixes-user-override bundle0.js 5.77 KiB 5.87 KiB +99 B (+1.68%) +36 B (+1.90%) +31 B (+1.95%) +38 B (+2.02%)
🔴 ↑ asset-modules/query-suffixes bundle0.js 27.16 KiB 27.25 KiB +99 B (+0.36%) +31 B (+0.18%) +31 B (+0.19%) +33 B (+0.19%)
🔴 ↑ analyzable/library-module-shipping 1/bundle1.mjs 7.86 KiB 7.96 KiB +94 B (+1.17%) +26 B (+1.06%) +20 B (+0.93%) +25 B (+1.02%)
🔴 ↑ analyzable/library-module-shipping 0/bundle0.mjs 7.86 KiB 7.96 KiB +94 B (+1.17%) +26 B (+1.06%) +20 B (+0.93%) +25 B (+1.02%)
🔴 ↑ analyzable/circular-chunkhash-names bundle0.mjs 7.54 KiB 7.62 KiB +80 B (+1.04%) +24 B (+1.04%) +16 B (+0.80%) +24 B (+1.05%)
🔴 ↑ analyzable/content-named-single-runtime main.[hash].mjs 1.67 KiB 1.74 KiB +66 B (+3.85%) +25 B (+3.76%) +30 B (+5.32%) +27 B (+4.04%)
🔴 ↑ analyzable/chunk-import-shared-initial-chunk bundle0.mjs 1.87 KiB 1.93 KiB +66 B (+3.45%) +28 B (+3.88%) +28 B (+4.59%) +29 B (+3.96%)
🔴 ↑ analyzable/shared-runtime-base-uri bundle0.mjs 2.30 KiB 2.37 KiB +66 B (+2.80%) +26 B (+3.06%) +31 B (+4.35%) +25 B (+2.88%)
🔴 ↑ analyzable/shared-chunk-import main.mjs 2.50 KiB 2.56 KiB +66 B (+2.58%) +28 B (+3.07%) +33 B (+4.24%) +27 B (+2.95%)
🔴 ↑ analyzable/public-path-override-scope bundle0.mjs 3.12 KiB 3.18 KiB +66 B (+2.07%) +29 B (+2.69%) +34 B (+3.73%) +28 B (+2.57%)
🔴 ↑ analyzable/asset-import-baked-absolute bundle0.mjs 3.25 KiB 3.32 KiB +66 B (+1.98%) +23 B (+2.17%) +32 B (+3.55%) +26 B (+2.45%)
🔴 ↑ analyzable/asset-import-baked bundle0.mjs 3.32 KiB 3.39 KiB +66 B (+1.94%) +26 B (+2.41%) +29 B (+3.13%) +28 B (+2.59%)
🔴 ↑ analyzable/protocol-relative-base-uri bundle0.mjs 3.44 KiB 3.51 KiB +66 B (+1.87%) +28 B (+2.28%) +34 B (+3.25%) +28 B (+2.27%)
🔴 ↑ asset-modules/url-module-public-path bundle0.mjs 3.69 KiB 3.75 KiB +66 B (+1.75%) +27 B (+2.08%) +37 B (+3.40%) +27 B (+2.06%)
🔴 ↑ wasm/analyzable-served-both-ways main.mjs 3.73 KiB 3.80 KiB +66 B (+1.73%) +29 B (+2.37%) +27 B (+2.57%) +28 B (+2.28%)
🔴 ↑ output/public-path-assign-only 0/assign-only/main.mjs 3.90 KiB 3.96 KiB +66 B (+1.65%) +28 B (+2.16%) +20 B (+1.81%) +31 B (+2.39%)
🔴 ↑ html/path-outside-context-future-defaults bundle0.js 4.21 KiB 4.27 KiB +66 B (+1.53%) +29 B (+2.03%) -9 B (-0.75%) +29 B (+2.03%)
🔴 ↑ analyzable/asset-url-function-public-path 0/bundle0.mjs 4.26 KiB 4.32 KiB +66 B (+1.51%) +29 B (+1.97%) +21 B (+1.67%) +31 B (+2.09%)
🔴 ↑ analyzable/asset-url-function-public-path 1/bundle1.mjs 4.26 KiB 4.32 KiB +66 B (+1.51%) +29 B (+1.97%) +23 B (+1.83%) +29 B (+1.96%)
… 544 more, see the uploaded report
13 asset(s) changed size, test edited
Asset Before After Change Gzip (9) Brotli (11) Zstd (19) Test edit (per test)
🔴 ↑ node/output-module-external import.mjs 8.68 KiB 8.95 KiB +275 B (+3.09%) +16 B (+0.62%) +4 B (+0.18%) +14 B (+0.55%) +5 B
🔴 ↑ node/output-module-external require.mjs 7.81 KiB 8.07 KiB +270 B (+3.38%) +3 B (+0.12%) -13 B (-0.59%) -1 B (-0.04%) +5 B
🔴 ↑ externals/node-prefix-user-externals strip/bundle0.js 1000 B 1.19 KiB +221 B (+22.10%) +31 B (+6.28%) +38 B (+9.18%) +30 B (+6.09%) +2.02 KiB
🔴 ↑ externals/node-prefix-user-externals keep/bundle1.js 1010 B 1.20 KiB +221 B (+21.88%) +31 B (+6.24%) +36 B (+8.53%) +29 B (+5.82%) +2.02 KiB
🔴 ↑ node/prefix-in-runtime 2/bundle2.mjs 368 B 378 B +10 B (+2.72%) +1 B (+0.40%) — — +40 B
🔴 ↑ node/prefix-in-runtime 0/bundle0.mjs 368 B 378 B +10 B (+2.72%) +1 B (+0.40%) — — +40 B
🔴 ↑ node/prefix-in-runtime 4/bundle4.mjs 368 B 378 B +10 B (+2.72%) +1 B (+0.40%) — — +40 B
🔴 ↑ node/prefix-in-runtime 5/bundle5.mjs 368 B 378 B +10 B (+2.72%) +1 B (+0.40%) — — +40 B
🔴 ↑ node/prefix-in-runtime 7/bundle7.js 596 B 606 B +10 B (+1.68%) +2 B (+0.53%) +1 B (+0.32%) +3 B (+0.81%) +40 B
🔴 ↑ node/prefix-in-runtime 6/bundle6.mjs 363 B 368 B +5 B (+1.38%) +2 B (+0.80%) +2 B (+0.96%) +3 B (+1.28%) +40 B
🔴 ↑ node/prefix-in-runtime 3/bundle3.mjs 363 B 368 B +5 B (+1.38%) +2 B (+0.80%) +2 B (+0.96%) +3 B (+1.28%) +40 B
🔴 ↑ node/prefix-in-runtime 1/bundle1.mjs 363 B 368 B +5 B (+1.38%) +2 B (+0.80%) +2 B (+0.96%) +3 B (+1.28%) +40 B
🔴 ↑ json/tree-shaking-default bundle0.js 1.97 KiB 1.98 KiB +5 B (+0.25%) +3 B (+0.36%) +4 B (+0.55%) +5 B (+0.61%) -1 B
2 asset(s) this pull request adds
Asset Raw Gzip (9) Brotli (11) Zstd (19)
⚪ added externals/node-prefix-module-id bundle0.js 3.24 KiB 1.10 KiB 924 B 1.10 KiB
⚪ added externals/node-prefix-user-externals add/bundle2.js 1.20 KiB 522 B 445 B 522 B

No runtime gained or lost a runtime module.

Built test/configCases with the defaults a user gets: 2204 test(s), 8343 asset(s), 99 emitted nothing.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Types Coverage

Coverage after merging fix/node-prefix-external-module-id into main will be
97.28%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
bin
   webpack.js98.82%100%100%98.82%103
declarations
   WebpackOptions.ts99.94%100%100%99.94%4183
examples
   build-common.js100%100%100%100%
   buildAll.js100%100%100%100%
   examples.js100%100%100%100%
   template-common.js98.21%100%100%98.21%72
examples/custom-javascript-parser
   test.filter.js100%100%100%100%
examples/custom-javascript-parser/internals
   acorn-parse.js100%100%100%100%
   meriyah-parse.js100%100%100%100%
   oxc-parse.js100%100%100%100%
examples/markdown
   webpack.config.mjs100%100%100%100%
examples/module-federation
   test.filter.js100%100%100%100%
examples/reexport-components
   test.filter.js100%100%100%100%
examples/ssr
   test.filter.js100%100%100%100%
examples/typescript
   test.filter.js100%100%100%100%
examples/typescript-non-erasable
   test.filter.js50%100%100%50%5
examples/virtual-modules
   test.filter.js100%100%100%100%
examples/wasm-bindgen-esm
   test.filter.js100%100%100%100%
examples/wasm-complex
   test.filter.js100%100%100%100%
examples/wasm-emscripten
   test.filter.js100%100%100%100%
examples/wasm-simple
   test.filter.js100%100%100%100%
examples/wasm-simple-source-phase
   test.filter.js100%100%100%100%
lib
   Chunk.js100%100%100%100%
   Compilation.js98.60%100%100%98.60%1757, 2078, 2085, 2093, 2115, 2118, 23, 3075, 3578–3579, 3611, 4200, 4204, 4331, 4352, 4477, 4514, 4521, 4574–4575, 4579, 4584, 4600–4601, 4615–4616, 4621–4622, 5145, 5171, 6001, 6018, 6036, 6052, 6067, 6092, 6095, 6463, 6466–6467, 6472, 6487, 6570, 6594, 6708, 837–838
   Compiler.js98.81%100%100%98.81%1116, 1153, 1156, 1336–1337, 1345, 848, 934, 975
   Dependency.js100%100%100%100%
   DependencyTemplate.js100%100%100%100%
   EntryPlugin.js100%100%100%100%
   Entrypoint.js100%100%100%100%
   ExternalsPlugin.js100%100%100%100%
   FileSystemInfo.js100%100%100%100%
   InitFragment.js100%100%100%100%
   LibraryTemplatePlugin.js100%100%100%100%
   ModuleFilenameHelpers.js100%100%100%100%
   ModuleNotFoundError.js100%100%100%100%
   MultiCompiler.js98.88%100%100%98.88%460, 532, 719, 784
   NormalModule.js100%100%100%100%
   NullFactory.js100%100%100%100%
   ProgressPlugin.js100%100%100%100%
   RawModule.js100%100%100%100%
   RequestShortener.js100%100%100%100%
   SingleEntryPlugin.js100%100%100%100%
   WebpackError.js100%100%100%100%
   index.js99.78%100%100%99.78%206
   webpack.js97.84%100%100%97.84%278, 300, 302
lib/asset
   AssetBytesGenerator.js100%100%100%100%
   AssetBytesParser.js100%100%100%100%
   AssetGenerator.js100%100%100%100%
   AssetModule.js100%100%100%100%
   AssetModulesPlugin.js98.15%100%100%98.15%338, 362, 365, 495, 57, 62
   AssetParser.js100%100%100%100%
   AssetSourceGenerator.js100%100%100%100%
   AssetSourceParser.js100%100%100%100%
   RawDataUrlModule.js100%100%100%100%
   WebManifestGenerator.js100%100%100%100%
   WebManifestParser.js100%100%100%100%
lib/async-modules
   AsyncModuleHelpers.js100%100%100%100%
   AwaitDependenciesInitFragment.js100%100%100%100%
   InferAsyncModulesPlugin.js100%100%100%100%
   isGeneratorLowered.js100%100%100%100%
lib/bun
   BunTargetPlugin.js100%100%100%100%
lib/cache
   AddBuildDependenciesPlugin.js100%100%100%100%
   AddManagedPathsPlugin.js100%100%100%100%
   Cache.js96.49%100%100%96.49%10, 104
   CacheFacade.js100%100%100%100%
   IdleFileCachePlugin.js97.92%100%100%97.92%75, 87, 95
   MemoryCachePlugin.js92%100%100%92%33, 42
   MemoryWithGcCachePlugin.js93.42%100%100%93.42%106, 120–121, 130, 88
   PackFileCacheStrategy.js96.54%100%100%96.54%1304, 1404, 1408, 1470, 1716, 1800, 1823, 1853, 682, 701, 711–713, 715, 731–732, 737, 740, 742, 747, 752, 777, 783, 817, 823, 829, 834, 845, 854, 859–860, 862, 879, 885–886, 888
   ResolverCachePlugin.js100%100%100%100%
   getLazyHashedEtag.js100%100%100%100%
   mergeEtags.js100%100%100%100%
lib/config
   OptionsApply.js100%100%100%100%
   PlatformPlugin.js100%100%100%100%
   WebpackOptionsApply.js100%100%100%100%
   WebpackOptionsDefaulter.js100%100%100%100%
   browserslistTargetHandler.js100%100%100%100%
   cli.js98.61%100%100%98.61%116, 546, 578, 628, 9
   defaults.js99.44%100%100%99.44%1624–1626, 1634, 283, 286, 291, 295
   defineConfig.js100%100%100%100%
   getClaimedAssetTypes.js100%100%100%100%
   normalization.js99.12%100%100%99.12%279–280, 346, 361
   target.js100%100%100%100%
   validateSchema.js94.67%100%100%94.67%100, 87, 89, 98
lib/container
   ContainerEntryDependency.js100%100%100%100%
   ContainerEntryModule.js100%100%100%100%
   ContainerEntryModuleFactory.js100%100%100%100%
   ContainerExposedDependency.js100%100%100%100%
   ContainerPlugin.js100%100%100%100%
   ContainerReferencePlugin.js100%100%100%100%
   FallbackDependency.js100%100%100%100%
   FallbackItemDependency.js100%100%100%100%
   FallbackModule.js100%100%100%100%
   FallbackModuleFactory.js100%100%100%100%
   HoistContainerReferencesPlugin.js100%100%100%100%
   ModuleFederationPlugin.js100%100%100%100%
   RemoteModule.js100%100%100%100%
   RemoteRuntimeModule.js100%100%100%100%
   RemoteToExternalDependency.js100%100%100%100%
   declaredRemotes.js100%100%100%100%
   moduleFederationHooks.js100%100%100%100%
   options.js100%100%100%100%
lib/context
   ContextExclusionPlugin.js100%100%100%100%
   ContextModule.js99.88%100%100%99.88%1494
   ContextModuleFactory.js95.66%100%100%95.66%230, 257, 276, 280–281, 289, 465, 486, 491, 532, 541, 543, 547, 550, 556–557
   ContextReplacementPlugin.js100%100%100%100%
lib/css
   CssGenerator.js99.47%100%100%99.47%1085, 136, 842
   CssInjectStyleRuntimeModule.js100%100%100%100%
   CssLoadingRuntimeModule.js100%100%100%100%
   CssModule.js83.16%100%100%83.16%197, 202–210, 212–217
   CssModulesPlugin.js99.86%100%100%99.86%886
   CssParser.js99.48%100%100%99.48%1034, 1065, 2396, 24, 3043, 3046, 3052, 3093, 3096, 3135, 3138, 3475, 5041, 5044, 918
   CssServerStylesRuntimeModule.js100%100%100%100%
   conventions.js98.65%100%100%98.65%93
   cssMinify.js97.50%100%100%97.50%162, 171
   data.js99.84%100%100%99.84%229, 5545
   syntax-parser.js99.64%100%100%99.64%10060–10061, 10595–10596, 10633, 10828, 10874, 13094–13097, 13197–13198, 13295–13296, 13940, 14237, 14239, 14729, 15095, 17105, 2444, 3143, 3145, 3150, 3169, 3914, 3920, 7356, 7394, 7401
   syntax-printer.js99.31%100%100%99.31%2530–2531, 2533–2534, 2536–2537, 2542, 2809–2812, 2905, 3578, 360, 3998, 4107, 4793, 5094, 5884, 730
   syntax.js100%100%100%100%
   topologicalSort.js100%100%100%100%
lib/debug
   ProfilingPlugin.js96.22%100%100%96.22%169, 425, 554, 561, 570, 574, 583, 588, 594, 599, 92
lib/define
   DefinePlugin.js98.85%100%100%98.85%1495, 268–269, 285, 304, 378, 936, 938, 943, 967
   DotenvPlugin.js98.07%100%100%98.07%391, 439, 452–453
   EnvironmentPlugin.js97.14%100%100%97.14%49
lib/deno
   DenoTargetPlugin.js100%100%100%100%
lib/dependencies
   ConstDependency.js100%100%100%100%
   ContextElementDependency.js100%100%100%100%
   NullDependency.js100%100%100%100%
lib/dependencies/amd
   AMDDefineDependency.js100%100%100%100%
   AMDDefineDependencyParserPlugin.js100%100%100%100%
   AMDPlugin.js99.31%100%100%99.31%54
   AMDRequireArrayDependency.js100%100%100%100%
   AMDRequireContextDependency.js100%100%100%100%
   AMDRequireDependenciesBlock.js100%100%100%100%
   AMDRequi

…truncated

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview is available (72cb6b9).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@72cb6b9
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@72cb6b9
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@72cb6b9

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.18%. Comparing base (01ee7b7) to head (72cb6b9).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #22565       +/-   ##
===========================================
+ Coverage   85.60%   96.18%   +10.57%     
===========================================
  Files         648      773      +125     
  Lines      123195   127997     +4802     
  Branches    41237    42441     +1204     
===========================================
+ Hits       105463   123114    +17651     
+ Misses      17732     4883    -12849     
Flag Coverage Δ
css-parsing 25.10% <12.50%> (-0.01%) ⬇️
html5lib 26.96% <12.50%> (-0.01%) ⬇️
integration 82.52% <100.00%> (+21.19%) ⬆️
minify-corpora 79.44% <ø> (?)
syntax-equivalence 79.63% <ø> (?)
test262 56.80% <37.50%> (?)
test262-parser 84.55% <ø> (ø)
unit 75.17% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 27.24%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 2 regressed benchmarks
✅ 401 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory benchmark "side-effects-reexport", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 155 KB 903.2 KB -82.84%
❌ Memory unit benchmark "js-parser-unit", source 'lodash-es' 107.5 KB 306.1 KB -64.88%
⚡ Memory benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 1,627.3 KB 787.2 KB ×2.1
⚡ Memory benchmark "future-defaults", scenario '{"name":"mode-production","mode":"production"}' 25.1 MB 18.9 MB +32.35%
⚡ Memory benchmark "asset-modules-source", scenario '{"name":"mode-production","mode":"production"}' 8.4 MB 6.8 MB +23.68%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/node-prefix-external-module-id (72cb6b9) with main (cdd1d8c)2

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (d763ce0) during the generation of this report, so cdd1d8c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

…vironment option is on

`output.environment.nodePrefixForCoreModules` now decides the spelling
of a core module external both ways: on, `require("path")` is written
`require("node:path")`; off, the prefix is stripped. The runtime's own
core module requests already followed the option.

Claude-Session: https://claude.ai/code/session_01ViD41i2KdwwGxrDk7yrjeD
@alexander-akait
alexander-akait merged commit 01aa214 into main Oct 9, 2026
68 of 69 checks passed
@alexander-akait
alexander-akait deleted the fix/node-prefix-external-module-id branch October 9, 2026 15:13
alexander-akait added a commit that referenced this pull request Oct 10, 2026
…n `node:` is supported (#22593)

* fix(externals): keep a core module external as the code spells it when `node:` is supported

#22565 also prefixed a bare core module external with `node:` whenever `output.environment.nodePrefixForCoreModules` was on. An unversioned `node` target turns that option on, so bundles run on Node 12 required `node:worker_threads` and failed. A bare external now stays bare again; only a universal bundle gains the prefix.

Claude-Session: https://claude.ai/code/session_01ViD41i2KdwwGxrDk7yrjeD

* fix(css): read a block owner's at-keyword through `_atKeywordOf` when ordering declarations

Ported from #22586: main throws minifying an at-rule block of several declarations, which fails this branch's lint, unit and CSS checks.

Claude-Session: https://claude.ai/code/session_01ViD41i2KdwwGxrDk7yrjeD
markharding pushed a commit to futo-org/Harbor that referenced this pull request Oct 20, 2026
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [webpack](https://github.com/webpack/webpack) | [`5.111.1` → `5.112.0`](https://renovatebot.com/diffs/npm/webpack/5.111.1/5.112.0) | ![age](https://developer.mend.io/api/mc/badges/age/npm/webpack/5.112.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/webpack/5.111.1/5.112.0?slim=true) |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/99) for more information.

---

### Release Notes

<details>
<summary>webpack/webpack (webpack)</summary>

### [`v5.112.0`](https://github.com/webpack/webpack/blob/HEAD/CHANGELOG.md#51120)

[Compare Source](webpack/webpack@v5.111.1...v5.112.0)

##### Minor Changes

- Apply `plugins` set on a multi-configuration array to the `MultiCompiler`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22702](webpack/webpack#22702))

- Add `optimization.minimize.css.dropOverriddenDeclarations`, dropping a declaration a later one overrides where no target is named. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22175](webpack/webpack#22175))

- Export more plugins under their scope, move eleven loose exports under theirs, deprecate the old, and expose `template.DependencyTemplate`, `module.NullFactory` and `util.makeSerializable`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22261](webpack/webpack#22261))

- Let `util.makeSerializable` take several requests, current one first. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22340](webpack/webpack#22340))

- Emit the source map `scopes` field, so a debugger resolves imported ESM bindings by name. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;21999](webpack/webpack#21999))

- Add `library.entryExports: "all"` to expose the exports of every entry module. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22235](webpack/webpack#22235))

- Recognize a required `const` binding assigned to `exports` as a re-export. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22276](webpack/webpack#22276))

- Accept glob patterns in more path, module and file filter options. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22422](webpack/webpack#22422))

- Bundle a run of inline `<script>` tags into one chunk the page can inline. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22188](webpack/webpack#22188))

- Add `module.parser.javascript.topLevelThis` for classic-script `this` semantics. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22193](webpack/webpack#22193))

- Add `module.parser.html.chunkName` and a `webpackChunkName` comment for tags. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22200](webpack/webpack#22200))

- Add `include`/`exclude` version and request filters to shared modules. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22297](webpack/webpack#22297))

- Keep module side-effect information in ESM output as PURE annotations. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;21789](webpack/webpack#21789))

- Add `optimization.splitChunks.dedupDepth` to discover chunk intersections. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22240](webpack/webpack#22240))

- Add `optimization.minimizeOptions.json`, on by default with `futureDefaults`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22286](webpack/webpack#22286))

- Add `SSRManifestPlugin` and fix server-rendered CSS collection and adoption. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;21913](webpack/webpack#21913))

- Add an `ignore` hook to `output.copy` and keep unfollowed `from` symlinks. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22216](webpack/webpack#22216))

- Add `optimization.minimize.css.convertApproximateColors`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22157](webpack/webpack#22157))

- Add XML parsing and SVG/XML minification with data URLs and attribute sorting. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22269](webpack/webpack#22269))

- Extract CSS/HTML license comments like JS and safely shorten CSS gradients. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22408](webpack/webpack#22408))

- Resolve an async `DefinePlugin.runtimeValue` over an async `beforeParse` hook. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22210](webpack/webpack#22210))

- Add CSS `customMedia`/`customSelectors` minimize options; resolve chained names. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22360](webpack/webpack#22360))

- Rename the `Harmony*` names to `ESM*` and deprecate the old spellings. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22283](webpack/webpack#22283))

- Reduce `css.syntax`/`html.syntax` to `parser`, `printer`, `SourceProcessor` with one node path. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22233](webpack/webpack#22233))

- Add a JavaScript `SyntaxTree` read like the CSS one, and `toEstreeObject`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22608](webpack/webpack#22608))

- Fix minified code that threw, and add `pure_conversions` and `pure_heritage`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22473](webpack/webpack#22473))

- Shorten more CSS values and selectors, fold longhands, order declarations and gather layer blocks. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22442](webpack/webpack#22442))

- Add `optimization.minimize.css.charset`; `false` drops `@charset` for UTF-8 CSS. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22632](webpack/webpack#22632))

##### Patch Changes

- Join rules a gathered `@layer` leaves adjacent, and an at-rule with a later one (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22204](webpack/webpack#22204))
  stating the same condition; read what a condition declares.

- Read escaped CSS names and functions as spelled, and minify them unescaped. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22262](webpack/webpack#22262))

- Minify JavaScript, CSS and HTML assets whose names carry a `#fragment`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22277](webpack/webpack#22277))

- Require `minimizer-webpack-plugin` 5.12, so inline scripts in HTML minify again. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22296](webpack/webpack#22296))

- Minify the attributes of an HTML tag without rewriting the template in it. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22166](webpack/webpack#22166))

- Order joined at-rule selector lists and gather a repeated large `@layer` block. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22224](webpack/webpack#22224))

- Preserve case-sensitive template identifiers when minifying HTML tag attributes. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22177](webpack/webpack#22177))

- Match Acorn's strict directives, Unicode identifiers and expression validation. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22185](webpack/webpack#22185))

- Skip concatenating modules when `optimization.providedExports` is disabled. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22410](webpack/webpack#22410))

- Join rules a nesting lowering or duplicate drop left for a second pass. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22268](webpack/webpack#22268))

- Write U+00A0 in a minified HTML attribute as the character, not `&nbsp;`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22208](webpack/webpack#22208))

- Escape a foreign `<script>` or `<style>` body, which is character data. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22233](webpack/webpack#22233))

- Name the runtime module whose generation fails while hashing. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22203](webpack/webpack#22203))

- Rebuild a module in watch when its missing unused dependencies swap. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22693](webpack/webpack#22693))

- Rebuild in watch mode when a file is deleted while a build is running. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22650](webpack/webpack#22650))

- Take out the declaration a lowered shorthand writes over, which its source spelling made look like a fallback. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22270](webpack/webpack#22270))

- Read a foreign `<script>` or `<style>` body as character data, not as raw text. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22258](webpack/webpack#22258))

- Keep an inline `<style>` body as written when rebuilding a page webpack emitted. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22265](webpack/webpack#22265))

- Fix minified HTML for `style` spellings, CSS quotes, `<noscript>` and a BOM. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22370](webpack/webpack#22370))

- Record a build dependency required through a spread on Bun. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22230](webpack/webpack#22230))

- Write a nested selector opening on a combinator against its parent the way the printer writes one. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22271](webpack/webpack#22271))

- Fix missing async stylesheets with a shared runtime. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22659](webpack/webpack#22659))

- Support deferred imports introduced by hot updates. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22668](webpack/webpack#22668))

- Fix trailing commas in `require.resolve()` and `require.resolveWeak()` calls. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22658](webpack/webpack#22658))

- Keep regular expressions, functions and plugins distinct in resolver caches. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22667](webpack/webpack#22667))

- Order the list a lowered nested selector lands in on what is written, not on what was. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22287](webpack/webpack#22287))

- Hoist a vendor-prefixed nested rule for a target that reads no nesting. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22308](webpack/webpack#22308))

- Name a hoisted nested rule in the dark-scheme copy it writes. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22318](webpack/webpack#22318))

- Minify data: URL payloads in HTML attributes and `new URL`, and web manifests. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22300](webpack/webpack#22300))

- fold a fallback's colors over the author's arguments, and print with (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22314](webpack/webpack#22314))
  `recurseBlocks: false` rather than throwing

- Read a regular expression repeating a capture group name in linear time. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22187](webpack/webpack#22187))

- Make lazy barrels defer import declarations and keep no deferral across compilations. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22359](webpack/webpack#22359))

- Invalidate unaffected caches when connection activity or async status changes. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22431](webpack/webpack#22431))

- Order concatenated re-exports deterministically when their source order ties. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22697](webpack/webpack#22697))

- Regenerate a module's exports when a require() cycle forms or breaks around it. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22644](webpack/webpack#22644))

- Recompute re-exports, code and warnings when a module goes missing or returns. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22432](webpack/webpack#22432))

- Preserve loader resolution dependencies across cached rebuilds. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22430](webpack/webpack#22430))

- Read unwatched changes afresh and wait for restarted watch compilers to finish. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22646](webpack/webpack#22646))

- Parse loader output for `.wasm` as JavaScript when async wasm is auto-enabled. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22556](webpack/webpack#22556))

- Remove modules an async chunk inherits from a named parent chunk grown later. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22555](webpack/webpack#22555))

- Fix JavaScript minifier crashes, altered behavior, lost comments, unparsable output and null source map sources, including parameter aliases, ESTree trees and preserved names, and stop it writing into the caller's parse options. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22352](webpack/webpack#22352))

- Preserve the source phase of dynamic WebAssembly import contexts. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22604](webpack/webpack#22604))

- Await every async entry before resolving an ESM library import. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22617](webpack/webpack#22617))

- Keep unknown `import.meta` properties per module, alike for aliases and direct use. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22618](webpack/webpack#22618))

- Return WebAssembly modules directly from eager and weak source imports. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22606](webpack/webpack#22606))

- Handle missing ESM hot update manifests in Node.js without failing HMR checks. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22613](webpack/webpack#22613))

- Speed up JavaScript parsing: comment lookup, the tokenizer and the grammar. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22179](webpack/webpack#22179))

- Name a core module external by its key whichever spelling the code uses. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22565](webpack/webpack#22565))

- Prefix and drop 2009 flexbox names, keeping them where a box lays out by them. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22320](webpack/webpack#22320))

- Keep `initial` where Gecko or WebKit reads the property's keyword apart. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22176](webpack/webpack#22176))

- Fold `calc()` as lightningcss does, keeping it where a bare value is refused. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22205](webpack/webpack#22205))

- Keep a `color-mix()` whose hue rests on a gray's conversion residue. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22198](webpack/webpack#22198))

- Keep a shorthand's initial keyword where it parts two keywords of another slot. (by [@&#8203;dependabot](https://github.com/apps/dependabot) in [#&#8203;22518](webpack/webpack#22518))

- Group `lib/` and `lib/dependencies/` sources into directories. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22118](webpack/webpack#22118))

- Treat a browserslist target given at a bare major version (e.g. `safari 10`) as `<major>.0` when a feature's first supported version is a `[major, minor]` pair, so it is no longer reported as unsupported. (by [@&#8203;Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#&#8203;22280](webpack/webpack#22280))

- Keep the last HMR update with `output.clean`; stop rechecking removed files. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22339](webpack/webpack#22339))

- Read and print a CSS backslash as the spec does, and a NUL as U+FFFD. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22201](webpack/webpack#22201))

- Make minified CSS and HTML stable on a second pass, even for truncated input. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22290](webpack/webpack#22290))

- Minify a merged `<style>` run as one sheet, closing each where its input ended. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22302](webpack/webpack#22302))

- Minify JavaScript with webpack's printer under `futureDefaults`, `terser` otherwise. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22217](webpack/webpack#22217))

- Preserve `wrappedContextRegExp` flags when rebuilding context request matchers. (by [@&#8203;Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#&#8203;22303](webpack/webpack#22303))

- Minify CSS `@supports`, `@import` and `@custom-media` conditions, and exponent numbers. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22347](webpack/webpack#22347))

- Fold unitless `hsl()`/`hwb()` channels, and only where the separators are valid. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22242](webpack/webpack#22242))

- Split `@value` imports on the `from` keyword, not a substring in the path. (by [@&#8203;Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#&#8203;22306](webpack/webpack#22306))

- Destructure a dotted `DefinePlugin` key whose value is falsy or a runtimeValue. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22215](webpack/webpack#22215))

- Make `Stats.hasErrors()` read errors through the `processErrors` hook (via `getErrors()`), matching `hasWarnings()`, so a plugin that filters errors out of the hook is no longer contradicted by `hasErrors()`. (by [@&#8203;Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#&#8203;22281](webpack/webpack#22281))

- Allow wrapping an external concatenated module, now asked of the module itself, and re-exporting a JSON or asset `default` as a namespace object. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22226](webpack/webpack#22226))

- Match `urlHints` rules written with `and`, `or`, `not` and `glob` conditions; profile hook map taps, such as resolver and parser hooks, in `ProfilingPlugin`; report `import.meta` option errors inside `require.ensure` callbacks, not crash; and replace `any`, `object` and `Function` with precise types in the type definitions. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22681](webpack/webpack#22681))

- Reduce CSS and HTML build time and memory allocation. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22135](webpack/webpack#22135))

- Reuse free names instead of re-parsing modules for the entry IIFE rename. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22206](webpack/webpack#22206))

- Release each module's ast once scope-analysed, and encode each export path once. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22241](webpack/webpack#22241))

- Export a module library entry's default expression as its own binding, and keep (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22227](webpack/webpack#22227))
  the export helpers where the entry is not inlined.

- Give a wrapped concatenated body the same function header as a module factory. (by [@&#8203;hai-x](https://github.com/hai-x) in [#&#8203;22254](webpack/webpack#22254))

- Skip reading every asset when no content hash is named. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22256](webpack/webpack#22256))

- Cut graph, cached set, lazy barrel and ESM import memory and allocations. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22289](webpack/webpack#22289))

- Stop a module source from being held as both a string and a buffer. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22294](webpack/webpack#22294))

- Read the browserslist data and options schema only when a build needs them. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22324](webpack/webpack#22324))

- Release the eval devtool's cached module sources after wrapping them. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22358](webpack/webpack#22358))

- Release the rendered module sources after emitting the chunks. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22365](webpack/webpack#22365))

- Cut the peak memory and time of minifying through webpack's printer. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22368](webpack/webpack#22368))

- Shrink minified JS: unwrap IIFEs, fold calls, drop dead code, split arrays. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22393](webpack/webpack#22393))

- Cut JavaScript minifier time and memory; keep token positions in large inputs. (by [@&#8203;bjohansebas](https://github.com/bjohansebas) in [#&#8203;22329](webpack/webpack#22329))

- Keep the `calc()` around a `steps()` count `jump-none` would reject bare. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22168](webpack/webpack#22168))

- Split the CSS syntax module into a parser file and a printer file. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22222](webpack/webpack#22222))

- Update enhanced-resolve to 5.26.0. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22358](webpack/webpack#22358))

- Update watchpack to 2.6.1. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22670](webpack/webpack#22670))

- Split the HTML syntax module into a parser file and a printer file. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22223](webpack/webpack#22223))

- Rename classes in `lib/` so each says what it does and no two share a name. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22361](webpack/webpack#22361))

- Keep the remote fallback index aligned with registered container externals when an `internal ` external precedes a real one. (by [@&#8203;Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#&#8203;22362](webpack/webpack#22362))

- Stop a minified inlined chunk leaving a doubled `;` in its `<script>`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22370](webpack/webpack#22370))

- Stop `mergeDistantRules` mangling rules or reordering `all`, and merge more. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22370](webpack/webpack#22370))

- Minify by parsing with webpack's own parser rather than terser's. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22397](webpack/webpack#22397))

- Read JavaScript with webpack's parser alone when minifying, refusing early errors. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22397](webpack/webpack#22397))

- Parse an `assert(...)` call after an import with no semicolon, and a regular expression after `yield` in a generator method. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22406](webpack/webpack#22406))

- Keep the private names a direct `eval` reads when mangling. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22412](webpack/webpack#22412))

- Keep a class dropped for its effects where they read a private name it declares. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22421](webpack/webpack#22421))

- Parenthesize the right side of a private `in`, a `yield`, `await`, private `in` or optional chain tagging a template, and a `let` or `async` starting a statement or loop head, where the minifier printed code that no longer parsed or read otherwise. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22437](webpack/webpack#22437))

- Keep a name a parameter list or catch parameter reads from resolving to what the function body or catch block declares, which the minifier renamed or dropped as unused. (by [@&#8203;aryanraj45](https://github.com/aryanraj45) in [#&#8203;22439](webpack/webpack#22439))

- Scope and export a CSS Modules `@value` the same way whether local or imported. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22443](webpack/webpack#22443))

- Keep CSS `border: none` and gradient fallbacks for units a target cannot read. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22567](webpack/webpack#22567))

- Keep minified CSS safe for older browsers; drop dead fallbacks and overrides. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22696](webpack/webpack#22696))

- Keep CSS rules apart from a neighbor whose selector no browser parses. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22634](webpack/webpack#22634))

- Keep an `:nth-*()` argument with a space after its sign as written. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22700](webpack/webpack#22700))

- Keep minified CSS readable by browsers the compat data does not cover. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22701](webpack/webpack#22701))

- Keep a module its chunk still needs after `compilation.rebuildModule()`. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22705](webpack/webpack#22705))

- Keep a CSS rule nested under a selector opening on a combinator when lowering. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22707](webpack/webpack#22707))

- Use module paths for webpack's built-in minimizers so parallel minification can load them directly in workers instead of serializing their function sources. (by [@&#8203;xiaoxiaojx](https://github.com/xiaoxiaojx) in [#&#8203;22309](webpack/webpack#22309))

- Keep stats from an earlier build readable after a later build no longer has one of their modules. (by [@&#8203;alexander-akait](https://github.com/alexander-akait) in [#&#8203;22695](webpack/webpack#22695))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - "before 9am on tuesday"
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjcuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE2Ny4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://code.futo.org/harbor/harbor/pulls/1941
Reviewed-by: Mark Harding <mark@futo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant